[SERVER-67531] Improve ShardSplit recipient cleanup logic Created: 24/Jun/22  Updated: 29/Oct/23  Resolved: 05/Jul/22

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 6.1.0-rc0

Type: Bug Priority: Major - P3
Reporter: Mathis Bessa Assignee: Mathis Bessa
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Server Serverless 2022-06-27, Server Serverless 2022-07-11
Participants:
Linked BF Score: 116

 Description   

When recipients are removed from the donor set and a primary on the recipient side is elected, the shard_split_donor_service will run and check to do the recipient state document cleanup.

However if that logic fails we should handle any potential error and avoid any extra logic to be ran for the recipient cleanup (decision and completion promise).

Additionally we should add logging when the recipient state document is successfully removed which would help troubleshoot any future ticket.

I also think it is worth investigating if we should remove the fsync logic within the assert.soon
We most likely only need to do that when we do the first commitShardSplit. Not at each retrytable error.



 Comments   
Comment by Githook User [ 05/Jul/22 ]

Author:

{'name': 'mathisbessamdb', 'email': 'mathis.bessa@mongodb.com', 'username': 'mathisbessamdb'}

Message: SERVER-67531 Improve recipient cleanup logic for shard split
Branch: master
https://github.com/mongodb/mongo/commit/53eea3da413a6ed0b4c3d91697467ccf8ad51342

Generated at Thu Feb 08 06:08:22 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.