[SERVER-67545] When auth is disabled, _mayBypassWriteBlockingMode should be set to true Created: 27/Jun/22 Updated: 29/Oct/23 Resolved: 29/Aug/22 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 6.2.0-rc0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Jenny Ren (Inactive) | Assignee: | Adam Rayner |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Sprint: | Security 2022-07-11, Security 2022-07-25, Security 2022-09-05 |
| Participants: |
| Description |
|
https://jira.mongodb.org/browse/SERVER-63174 The above ticket introduced logic to compute _mayBypassWriteBlockingMode, however, the logic is invoked even when auth is disabled, which incurs a small (and unnecessary) performance overhead. _mayBypassWriteBlockingMode should be directly set to true when auth is disabled. |
| Comments |
| Comment by Githook User [ 26/Aug/22 ] |
|
Author: {'name': 'Adam Rayner', 'email': 'adam.rayner@gmail.com'}Message: |
| Comment by Daniel Gottlieb (Inactive) [ 27/Jul/22 ] |
|
We did see a perf hit due to this cost. It's significant in some contexts, but not in others. To elaborate:
I too am not particularly concerned with fixing this for the sake of being hygienic. My main motivation to address this is to remove the noise when profiling in an effort to make performance improvements. If this is deemed a safe change anyone can make, I'm happy to take it on myself. |
| Comment by Adam Rayner [ 15/Jul/22 ] |
|
jenny.ren@mongodb.com thanks for raising this, but after internal discussion with the team I am closing this as won't do:
Certainly if there is additional performance information driving this request, let me know and happy to re-evaluate these assumptions. |