[SERVER-67662] [4.4] evergreen.yml "scons lint" fails to handle empty string for is_patch variable Created: 29/Jun/22  Updated: 29/Oct/23  Resolved: 30/Jun/22

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.4.16

Type: Bug Priority: Major - P3
Reporter: Benety Goh Assignee: Benety Goh
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to SERVER-40474 Run linting out of scons process Closed
is related to SERVER-55300 Implement expansions handling for sta... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Execution Team 2022-07-11
Participants:

 Description   

The is_patch check in the scons lint task expects is_patch to be a non-empty string but this is no longer the case in light of recent changes in the CI system. As a result, for non-patch builds, this results in the following shell error:

 [2022/06/29 17:47:23.925] echo "Found mypy executable at '$MYPY'"
 [2022/06/29 17:47:23.925] export extra_flags=""
 [2022/06/29 17:47:23.925] if [[  == "true" ]]; then
 [2022/06/29 17:47:23.925] sh: line 39: conditional binary operator expected



 Comments   
Comment by Githook User [ 29/Jun/22 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-67662 scons lint should handle empty string for is_patch variable
Branch: v4.4
https://github.com/mongodb/mongo/commit/d0118dc260b3272de2f78ea3d2eb2024e3143916

Comment by Benety Goh [ 29/Jun/22 ]

The ${is_patch|false} expansion was added in SERVER-40474, which was not backported to 4.2 and earlier. versions, so this issue affects the 4.4 branch only.

Comment by Benety Goh [ 29/Jun/22 ]

This does not impact branches that contain SERVER-55300, which moved this logic out of evergreen.yml into scons_lint.sh.

Generated at Thu Feb 08 06:08:43 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.