[SERVER-67704] Add count of cpu sockets to FTDC metadata Created: 30/Jun/22  Updated: 29/Oct/23  Resolved: 09/Dec/22

Status: Closed
Project: Core Server
Component/s: Diagnostics
Affects Version/s: None
Fix Version/s: 4.4.19, 5.0.15, 6.0.4, 6.3.0-rc0

Type: Improvement Priority: Major - P3
Reporter: Kevin Arhelger Assignee: Gabriel Marks
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
Problem/Incident
Related
related to SERVER-67705 Add count of NUMA zones to FTDC metadata Closed
Backwards Compatibility: Fully Compatible
Backport Requested:
v6.0, v5.0, v4.4
Sprint: Security 2022-11-14, Security 2022-11-28, Security 2022-12-12
Participants:
Linked BF Score: 105

 Description   

Currently, FTDC includes a count of "physical" cores by counting unique pairs of physical id and core id. https://github.com/mongodb/mongo/blob/master/src/mongo/util/processinfo_linux.cpp#L397

However, it would be incredibly useful to determine if the machine has multiple sockets and this data is not currently present in FTDC.



 Comments   
Comment by Githook User [ 09/Dec/22 ]

Author:

{'name': 'Gabriel Marks', 'email': 'gabriel.marks@mongodb.com', 'username': 'marksg07'}

Message: SERVER-67704 SERVER-67705 Fix processor package counting for ARM
Branch: v4.4
https://github.com/mongodb/mongo/commit/549900f16e9c93ddc0edcf682edb54c33b7f9cf2

Comment by Githook User [ 09/Dec/22 ]

Author:

{'name': 'Gabriel Marks', 'email': 'gabriel.marks@mongodb.com', 'username': 'marksg07'}

Message: Revert "SERVER-67704 SERVER-67705 Fix processor package counting for ARM"

This reverts commit ca53263a7b6caa8f1596725ce49aff47266ff941.
Branch: v4.4
https://github.com/mongodb/mongo/commit/35128279069e18c8e205d45ac44fad2b812cb8b3

Comment by Githook User [ 06/Dec/22 ]

Author:

{'name': 'Gabriel Marks', 'email': 'gabriel.marks@mongodb.com', 'username': 'marksg07'}

Message: SERVER-67704 SERVER-67705 Fix processor package counting for ARM
Branch: v6.0
https://github.com/mongodb/mongo/commit/01d06e110ce176b3e803352d470c91e1abcc36d5

Comment by Githook User [ 06/Dec/22 ]

Author:

{'name': 'Gabriel Marks', 'email': 'gabriel.marks@mongodb.com', 'username': 'marksg07'}

Message: SERVER-67704 SERVER-67705 Fix processor package counting for ARM
Branch: v5.0
https://github.com/mongodb/mongo/commit/0bec27e9d02d90c6c62986f43ce507e55761e73b

Comment by Githook User [ 06/Dec/22 ]

Author:

{'name': 'Gabriel Marks', 'email': 'gabriel.marks@mongodb.com', 'username': 'marksg07'}

Message: SERVER-67704 SERVER-67705 Fix processor package counting for ARM
Branch: v4.4
https://github.com/mongodb/mongo/commit/ca53263a7b6caa8f1596725ce49aff47266ff941

Comment by Githook User [ 29/Nov/22 ]

Author:

{'name': 'Gabriel Marks', 'email': 'gabriel.marks@mongodb.com', 'username': 'marksg07'}

Message: SERVER-67704 SERVER-67705 Fix processor package counting for ARM
Branch: master
https://github.com/mongodb/mongo/commit/e88f9219666b223ee6f5fc621d2a0abdf44f392a

Comment by Githook User [ 23/Nov/22 ]

Author:

{'name': 'Sviatlana Zuiko', 'email': 'sviatlana.zuiko@mongodb.com', 'username': 'szuiko'}

Message: Revert "SERVER-67704 SERVER-67705 Update host info to include CPU socket count + NUMA node count"

This reverts commit 327c538ae2cc1afa63c8ec68b84975ca2e93df74.
Branch: master
https://github.com/mongodb/mongo/commit/a42f617f8c91c7d3ad2e99914bad71380fee5a24

Comment by Kevin Arhelger [ 22/Nov/22 ]

Requesting backport since this will allow easier detection of multi-socket scalability issues on current versions. Since this data is currently missing in FTDC, it is difficult to understand if socket contention is at play.

Comment by Githook User [ 22/Nov/22 ]

Author:

{'name': 'Gabriel Marks', 'email': 'gabriel.marks@mongodb.com', 'username': 'marksg07'}

Message: SERVER-67704 SERVER-67705 Update host info to include CPU socket count + NUMA node count
Branch: master
https://github.com/mongodb/mongo/commit/327c538ae2cc1afa63c8ec68b84975ca2e93df74

Comment by Kevin Arhelger [ 19/Jul/22 ]

I agree with bruce.lucas@mongodb.com thoughts. Additionally SERVER-67705 would count NUMA zones which may be useful as well.

Comment by Bruce Lucas (Inactive) [ 05/Jul/22 ]

Initial thought is that FTDC metadata is the right place to put this, not a constant FTDC metric. It might be useful to generalize this a bit to have complete counts - physical CPUs (sockets), cores, and threads.

Comment by Chris Kelly [ 05/Jul/22 ]

Thanks for linking the git function, Kevin! It looks like Service Architecture put that function together some time ago, but FTDC is owned by Security. I'll pass it along to them to see how they want to approach it.

 

 

Generated at Thu Feb 08 06:08:50 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.