[SERVER-67704] Add count of cpu sockets to FTDC metadata Created: 30/Jun/22 Updated: 29/Oct/23 Resolved: 09/Dec/22 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Diagnostics |
| Affects Version/s: | None |
| Fix Version/s: | 4.4.19, 5.0.15, 6.0.4, 6.3.0-rc0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Kevin Arhelger | Assignee: | Gabriel Marks |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||
| Backport Requested: |
v6.0, v5.0, v4.4
|
||||||||||||||||||||
| Sprint: | Security 2022-11-14, Security 2022-11-28, Security 2022-12-12 | ||||||||||||||||||||
| Participants: | |||||||||||||||||||||
| Linked BF Score: | 105 | ||||||||||||||||||||
| Description |
|
Currently, FTDC includes a count of "physical" cores by counting unique pairs of physical id and core id. https://github.com/mongodb/mongo/blob/master/src/mongo/util/processinfo_linux.cpp#L397 However, it would be incredibly useful to determine if the machine has multiple sockets and this data is not currently present in FTDC. |
| Comments |
| Comment by Githook User [ 09/Dec/22 ] |
|
Author: {'name': 'Gabriel Marks', 'email': 'gabriel.marks@mongodb.com', 'username': 'marksg07'}Message: |
| Comment by Githook User [ 09/Dec/22 ] |
|
Author: {'name': 'Gabriel Marks', 'email': 'gabriel.marks@mongodb.com', 'username': 'marksg07'}Message: Revert " This reverts commit ca53263a7b6caa8f1596725ce49aff47266ff941. |
| Comment by Githook User [ 06/Dec/22 ] |
|
Author: {'name': 'Gabriel Marks', 'email': 'gabriel.marks@mongodb.com', 'username': 'marksg07'}Message: |
| Comment by Githook User [ 06/Dec/22 ] |
|
Author: {'name': 'Gabriel Marks', 'email': 'gabriel.marks@mongodb.com', 'username': 'marksg07'}Message: |
| Comment by Githook User [ 06/Dec/22 ] |
|
Author: {'name': 'Gabriel Marks', 'email': 'gabriel.marks@mongodb.com', 'username': 'marksg07'}Message: |
| Comment by Githook User [ 29/Nov/22 ] |
|
Author: {'name': 'Gabriel Marks', 'email': 'gabriel.marks@mongodb.com', 'username': 'marksg07'}Message: |
| Comment by Githook User [ 23/Nov/22 ] |
|
Author: {'name': 'Sviatlana Zuiko', 'email': 'sviatlana.zuiko@mongodb.com', 'username': 'szuiko'}Message: Revert " This reverts commit 327c538ae2cc1afa63c8ec68b84975ca2e93df74. |
| Comment by Kevin Arhelger [ 22/Nov/22 ] |
|
Requesting backport since this will allow easier detection of multi-socket scalability issues on current versions. Since this data is currently missing in FTDC, it is difficult to understand if socket contention is at play. |
| Comment by Githook User [ 22/Nov/22 ] |
|
Author: {'name': 'Gabriel Marks', 'email': 'gabriel.marks@mongodb.com', 'username': 'marksg07'}Message: |
| Comment by Kevin Arhelger [ 19/Jul/22 ] |
|
I agree with bruce.lucas@mongodb.com thoughts. Additionally |
| Comment by Bruce Lucas (Inactive) [ 05/Jul/22 ] |
|
Initial thought is that FTDC metadata is the right place to put this, not a constant FTDC metric. It might be useful to generalize this a bit to have complete counts - physical CPUs (sockets), cores, and threads. |
| Comment by Chris Kelly [ 05/Jul/22 ] |
|
Thanks for linking the git function, Kevin! It looks like Service Architecture put that function together some time ago, but FTDC is owned by Security. I'll pass it along to them to see how they want to approach it.
|