[SERVER-67845] Acquire critical section in rename "check preconditions" phase only if target not sharded Created: 07/Jul/22  Updated: 29/Oct/23  Resolved: 13/Jul/22

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 6.0.1, 5.0.11, 6.1.0-rc0

Type: Task Priority: Major - P3
Reporter: Pierlauro Sciarelli Assignee: Pierlauro Sciarelli
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Problem/Incident
causes SERVER-73385 RenameCollectionCoordinator wrongly r... Closed
Related
related to SERVER-67325 Collection creation must be disallowe... Closed
Backwards Compatibility: Fully Compatible
Backport Requested:
v6.0, v5.0
Sprint: Sharding EMEA 2022-07-11, Sharding EMEA 2022-07-25
Participants:

 Description   

The distributed lock is preventing overlaps between the critical section acquired by migrations and rename coordinators. As there is a plan to get rid of the distributed lock, purpose of this ticket is to acquire the critical section for the target collection only in case it is not sharded.

This is fine because SERVER-67325 introduced the acquisition of the critical section to avoid concurrent collections creation, but if a collection is already sharded that cannot happen.



 Comments   
Comment by Githook User [ 27/Jul/22 ]

Author:

{'name': 'Pierlauro Sciarelli', 'email': 'pierlauro.sciarelli@mongodb.com', 'username': 'pierlauro'}

Message: SERVER-67845 Acquire critical section in rename "check preconditions" phase only if target not sharded
Branch: v5.0
https://github.com/mongodb/mongo/commit/24013503c0cd1244c154594e17b8aca6281bdeab

Comment by Githook User [ 26/Jul/22 ]

Author:

{'name': 'Pierlauro Sciarelli', 'email': 'pierlauro.sciarelli@mongodb.com', 'username': 'pierlauro'}

Message: SERVER-67845 Acquire critical section in rename "check preconditions" phase only if target not sharded
Branch: v6.0
https://github.com/mongodb/mongo/commit/cd1400b89f1da5a6d7a85339c836d27584ccc3b9

Comment by Pierlauro Sciarelli [ 13/Jul/22 ]

Requesting backports to v5.0 and v6.0 that should also include SERVER-67325

Comment by Githook User [ 13/Jul/22 ]

Author:

{'name': 'Pierlauro Sciarelli', 'email': 'pierlauro.sciarelli@mongodb.com', 'username': 'pierlauro'}

Message: SERVER-67845 Acquire critical section in rename "check preconditions" phase only if target not sharded
Branch: master
https://github.com/mongodb/mongo/commit/47f99d9faa45b2fdf86082fc1221c6fc16536c3f

Generated at Thu Feb 08 06:09:12 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.