[SERVER-684] put oplog scanning logic in special case cursor impl Created: 01/Mar/10  Updated: 12/Jul/16  Resolved: 09/Mar/10

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 1.3.4

Type: Improvement Priority: Minor - P4
Reporter: Aaron Staple Assignee: Aaron Staple
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Participants:

 Comments   
Comment by auto [ 09/Mar/10 ]

Author:

{'login': 'astaple', 'name': 'Aaron', 'email': 'aaron@10gen.com'}

Message: SERVER-684 refactor findingStart code
http://github.com/mongodb/mongo/commit/57d2a1d901d7bbd2bb433ff17ba3d1ea819350ea

Comment by Aaron Staple [ 09/Mar/10 ]

It's a nested class in UserQueryOp right now
I can move to repl, no prob.

Comment by Eliot Horowitz (Inactive) [ 09/Mar/10 ]

No - i'm sure its fine.
I just really wanted the logic out of UserQueryOp and in a repl file

Comment by Aaron Staple [ 09/Mar/10 ]

I've already refactored to a special class (now testing). Maybe you can take a look and let me know if you want it to be more like a standard Cursor for some reason.

Comment by Eliot Horowitz (Inactive) [ 09/Mar/10 ]

I see - what do you think it should be? Just a method?

Comment by Aaron Staple [ 09/Mar/10 ]

What I am saying is that I don't think it should be a subclass of Cursor - since the locking strategy is completely different.

Comment by Eliot Horowitz (Inactive) [ 09/Mar/10 ]

right, i agree.
probably a subclass of Cursor that lives in repl.cpp

Comment by Aaron Staple [ 09/Mar/10 ]

I don't think it makes sense to have this functionality in a "cursor.h" Cursor, but I can refactor to a special purpose class.

Generated at Thu Feb 08 02:54:52 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.