[SERVER-68404] fle2Compact command should not prevent FCV transition during the entire duration of the operation Created: 28/Jul/22 Updated: 02/Aug/22 Resolved: 02/Aug/22 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | 6.0.0 |
| Fix Version/s: | None |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Tommaso Tocci | Assignee: | Erwin Pe |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Sprint: | Security 2022-08-08 | ||||||||
| Participants: | |||||||||
| Description |
|
fle2Compact command is holding the FixedFCVRegion raii lock for the the entire duration of the operation , thus preventing FCV transition while the coordinator is running. Instead we should release the FCV lock after the coordiantor has been created (getOrCreateInstance()) and before we wait for the response (getResponse()) |
| Comments |
| Comment by Erwin Pe [ 02/Aug/22 ] |
|
Apart from preventing FCV transition until the compact coordinator returns a response (which we see as a minor issue), we see no other significant issues that could arise from the shardsvr compact command holding onto the FixedFCVRegion lock. We expect the compaction command to be infrequently run, thus making it unlikely for this scenario to occur. For these reasons, we are inclined to simply leave this alone in 6.0. |