[SERVER-6848] SConstruct mixes tabs and spaces -- the tabs should be 8 spaces Created: 24/Aug/12  Updated: 11/Jul/16  Resolved: 03/Sep/12

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 2.3.0

Type: Bug Priority: Major - P3
Reporter: Tad Marshall Assignee: Tad Marshall
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Operating System: ALL
Participants:

 Description   

The SConstruct file at the top of the source tree in master and 2.2 branches uses tabs for indenting at lines 558, 560, 562 and 563.

The code works correctly because Python interprets each tab as 8 spaces, but it looks wrong in any editor set to show 4 spaces per tab. We should replace each tab with 8 spaces (which will make it look right) to prevent future accidents (and for consistency with the "don't use tabs" rule).



 Comments   
Comment by auto [ 03/Sep/12 ]

Author:

{u'date': u'2012-09-02T05:21:46-07:00', u'name': u'Tad Marshall', u'email': u'tad@10gen.com'}

Message: SERVER-6848 Replace tabs with 8 spaces in SConstruct
Branch: master
https://github.com/mongodb/mongo/commit/3f8a82f94aac4d6152038c42e5b1824dc081442c

Comment by Tad Marshall [ 02/Sep/12 ]

Code review url: http://codereview.10gen.com/8339078

Generated at Thu Feb 08 03:12:52 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.