[SERVER-68793] Investigate if AdmissionContext::_startProcessingTime is valid during resize Created: 12/Aug/22  Updated: 29/Oct/23  Resolved: 05/Sep/22

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 6.2.0-rc0

Type: Task Priority: Major - P3
Reporter: Haley Connelly Assignee: Jordi Olivares Provencio
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to SERVER-68933 AdmissionContext can be created witho... Closed
Backwards Compatibility: Fully Compatible
Sprint: Execution Team 2022-08-22, Execution Team 2022-09-05, Execution Team 2022-09-19
Participants:

 Description   

Prior to SERVER-67905, AdmissionContext::_startProcessingTime was initialized as follows 

TickSource::Tick _startProcessingTime{}; 

Now, it is initialized as 

TickSource::Tick _startProcessingTime{0};

We should check if initializing the TicketSource tick to 0 instead of its default {} means the _startProcessingTime computed for ticketHolders will spit unrealistic values when the ticketHolder is resized. 

Example: TicketHolderWithQueueingStats::resize() calls TicketHolderWithQueueingStats::_release() with an AdmissionContext defined on the stack that never has its _startProcessingTime initialized to a non-zero value before it is used to compute the _totalTimeProcessingMicros

 



 Comments   
Comment by Githook User [ 05/Sep/22 ]

Author:

{'name': 'Jordi Olivares Provencio', 'email': 'jordi.olivares-provencio@mongodb.com', 'username': 'jordiolivares'}

Message: SERVER-68793 Refactor TicketHolder::resize() in all implementations
Branch: master
https://github.com/mongodb/mongo/commit/fcdfe29cee066278b94ea2749456fc433cc398c6

Comment by Haley Connelly [ 16/Aug/22 ]

We should be testing the resize() method since there aren't existing tests for it.

Generated at Thu Feb 08 06:11:45 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.