[SERVER-68826] Pull some widely-used value types under mongo/db into a base library Created: 15/Aug/22  Updated: 29/Oct/23  Resolved: 23/Aug/22

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: None
Fix Version/s: 6.1.0-rc0, 6.2.0-rc0

Type: Improvement Priority: Major - P3
Reporter: Kaloian Manassiev Assignee: Kaloian Manassiev
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Problem/Incident
Backwards Compatibility: Fully Compatible
Sprint: Sharding EMEA 2022-09-05
Participants:
Linked BF Score: 165

 Description   

There are a set of common widely-used value types that 99% of the binaries under mongo/db need to reference. We should put them under a mongo/db/base library, similar to how mongo/base works.

Here are some initial candidates of .cpp files that need to go in there:

tenant_id.cpp
database_name.cpp
namespace_string.cpp
shard_id.cpp



 Comments   
Comment by Githook User [ 31/Aug/22 ]

Author:

{'name': 'Kaloian Manassiev', 'email': 'kaloian.manassiev@mongodb.com', 'username': 'kaloianm'}

Message: SERVER-68826 Reintroduce sasl_client into the mongoldap binary
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/1c974603e9aacbbb7e1011e15666243e9914ca6c

Comment by Githook User [ 29/Aug/22 ]

Author:

{'name': 'Kaloian Manassiev', 'email': 'kaloian.manassiev@mongodb.com', 'username': 'kaloianm'}

Message: SERVER-68826 Move logical_time into server_base
Branch: master
https://github.com/mongodb/mongo/commit/d5978f3d85b3764a3876553a893f458485dc6d3d

Comment by Githook User [ 29/Aug/22 ]

Author:

{'name': 'Kaloian Manassiev', 'email': 'kaloian.manassiev@mongodb.com', 'username': 'kaloianm'}

Message: SERVER-68826 Move logical_time into server_base
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/923ad65f91110d38861649e0227a306c9fb3ac26

Comment by Githook User [ 26/Aug/22 ]

Author:

{'name': 'Kaloian Manassiev', 'email': 'kaloian.manassiev@mongodb.com', 'username': 'kaloianm'}

Message: SERVER-68826 Move basic_types into server_base
Branch: master
https://github.com/mongodb/mongo/commit/0c95addd6131bbc4604590d2d04dc079c7c87847

Comment by Githook User [ 26/Aug/22 ]

Author:

{'name': 'Kaloian Manassiev', 'email': 'kaloian.manassiev@mongodb.com', 'username': 'kaloianm'}

Message: SERVER-68826 Move basic_types into server_base
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/f10b060816fe9c8cbdc5157fa41ba4a2b66853bd

Comment by Kaloian Manassiev [ 23/Aug/22 ]

There are a few more left that can be moved to server_base:
chunk_version.cpp
logical_session_id.cpp
write_concern_options.cpp
read_concern_args.cpp

Comment by Kaloian Manassiev [ 23/Aug/22 ]

Author:

{'name': 'Kaloian Manassiev', 'email': 'kaloian.manassiev@mongodb.com', 'username': 'kaloianm'}

Message: SERVER-68826 Fold tenant_id into the server_base library
Branch: master
https://github.com/mongodb/mongo/commit/1b7901911131fd073092ff5833214b12eea4a0c3

Comment by Githook User [ 23/Aug/22 ]

Author:

{'name': 'Kaloian Manassiev', 'email': 'kaloian.manassiev@mongodb.com', 'username': 'kaloianm'}

Message: SERVER-68826 Fold tenant_id into the server_base library
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/29e7be005542e482f676c8c0194e9aa2c2f64c54

Comment by Githook User [ 18/Aug/22 ]

Author:

{'name': 'Kaloian Manassiev', 'email': 'kaloian.manassiev@mongodb.com', 'username': 'kaloianm'}

Message: SERVER-68826 Introduce the server_base library
Branch: master
https://github.com/mongodb/mongo/commit/180f4490bfcb1600bec464d65529e03ba11e9717

Generated at Thu Feb 08 06:11:50 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.