[SERVER-68853] Remove invariant that a session stat needs to be a slow op stat Created: 16/Aug/22  Updated: 29/Oct/23  Resolved: 16/Aug/22

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 5.0.15, 6.0.4, 6.1.0-rc0

Type: Improvement Priority: Major - P3
Reporter: Sulabh Mahajan Assignee: Sulabh Mahajan
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
is depended on by WT-8848 Add API to roll back and indicate tha... Closed
Related
related to SERVER-68739 Add WiredTiger session statistic with... Closed
Backwards Compatibility: Fully Compatible
Backport Requested:
v6.0, v5.0
Sprint: Execution Team 2022-08-22
Participants:

 Description   

WiredTigerOperationStats::toBSON() has an invariant that gets triggered if WiredTiger adds a new session statistic without adding that stat into the storage's slow operation statistics:

     for (auto const& stat : _stats) {
         // Find the user consumable name for this statistic.
         auto statIt = _statNameMap.find(stat.first);
         invariant(statIt != _statNameMap.end());

WT-8848 is adding a session statistic that is not going to be a part of slow operation statistics. Remove the invariant and just ignore the statistic that is not part of the _statNameMap.



 Comments   
Comment by Githook User [ 16/Jan/23 ]

Author:

{'name': 'Sulabh Mahajan', 'email': 'sulabh.mahajan@mongodb.com', 'username': 'sulabhM'}

Message: SERVER-68853 Remove invariant that a session stat needs to be a slow op stat
Branch: v5.0
https://github.com/mongodb/mongo/commit/ab6b1c561d9f070125f7547820d76b14f3dc8427

Comment by Githook User [ 10/Jan/23 ]

Author:

{'name': 'Sulabh Mahajan', 'email': 'sulabh.mahajan@mongodb.com', 'username': 'sulabhM'}

Message: SERVER-68853 Remove invariant that a session stat needs to be a slow op stat
Branch: v6.0
https://github.com/mongodb/mongo/commit/e4d8086d418d41c197a93dedff120d0df780764b

Comment by Githook User [ 16/Aug/22 ]

Author:

{'name': 'Sulabh Mahajan', 'email': 'sulabh.mahajan@mongodb.com', 'username': 'sulabhM'}

Message: SERVER-68853 Remove invariant that a session stat needs to be a slow op stat
Branch: master
https://github.com/mongodb/mongo/commit/9fae3794e7b40acebd4d8d7c6d400c245f90ff28

Generated at Thu Feb 08 06:11:54 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.