[SERVER-68925] Reintroduce check table logging settings at startup (revert SERVER-43664) Created: 18/Aug/22  Updated: 29/Oct/23  Resolved: 26/Aug/22

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.2.23, 4.4.17, 5.0.12, 6.0.2, 6.1.0-rc1, 6.2.0-rc0

Type: Task Priority: Critical - P2
Reporter: Josef Ahmad Assignee: Gregory Wlodarek
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
Problem/Incident
Related
is related to SERVER-68908 Index builds in standalone mode shoul... Closed
Backwards Compatibility: Fully Compatible
Backport Requested:
v6.1
Sprint: Execution Team 2022-09-05
Participants:
Case:

 Description   

Revisit the optimisation introduced in SERVER-43664 which effectively skipped checking and repairing log settings for WT tables at startup. This improved the startup time on deployment with a large number of tables, at the cost of not catching and resolving table logging inconsistencies. We have observed an incident where one such inconsistency was discovered long after it was introduced, and at that point it was hard to recover from.

This ticket is a more comprehensive alternative to SERVER-68908 because it will also detect and resolve pre-existing inconsistencies.



 Comments   
Comment by Githook User [ 19/Sep/22 ]

Author:

{'name': 'Melissa Mahoney', 'email': 'melissa.mahoney@mongodb.com', 'username': 'melissamahoney-mongodb'}

Message: (DOCSP-24868): Critical Advisory for SERVER-68925 (#4599)
Branch: master
https://github.com/10gen/mms-docs/commit/5b0e3fe38555ddc0e96b84c4818b92a3d17f0b87

Comment by Githook User [ 26/Aug/22 ]

Author:

{'name': 'Gregory Wlodarek', 'email': 'gregory.wlodarek@mongodb.com', 'username': 'GWlodarek'}

Message: SERVER-68925 Reintroduce check table logging settings at startup

(cherry picked from commit 994562a9c82fd89549ac8ee0861eb9f10509d32c)
Branch: v4.2
https://github.com/mongodb/mongo/commit/8dd7f66d46cead919bbe13554c3543d16b16a385

Comment by Githook User [ 26/Aug/22 ]

Author:

{'name': 'Gregory Wlodarek', 'email': 'gregory.wlodarek@mongodb.com', 'username': 'GWlodarek'}

Message: SERVER-68925 Reintroduce check table logging settings at startup

(cherry picked from commit 994562a9c82fd89549ac8ee0861eb9f10509d32c)
Branch: v4.4
https://github.com/mongodb/mongo/commit/5b869743062ced761690c504e77c48b72cd14e6a

Comment by Githook User [ 26/Aug/22 ]

Author:

{'name': 'Gregory Wlodarek', 'email': 'gregory.wlodarek@mongodb.com', 'username': 'GWlodarek'}

Message: SERVER-68925 Reintroduce check table logging settings at startup

(cherry picked from commit 994562a9c82fd89549ac8ee0861eb9f10509d32c)
Branch: v6.0
https://github.com/mongodb/mongo/commit/d05a7e1e952cd109506a71a116d9aac6e96c74fa

Comment by Githook User [ 26/Aug/22 ]

Author:

{'name': 'Gregory Wlodarek', 'email': 'gregory.wlodarek@mongodb.com', 'username': 'GWlodarek'}

Message: SERVER-68925 Reintroduce check table logging settings at startup

(cherry picked from commit 994562a9c82fd89549ac8ee0861eb9f10509d32c)
Branch: v5.0
https://github.com/mongodb/mongo/commit/4b504aaf5c9166e0ce1ff08755ef93c62666beec

Comment by Githook User [ 26/Aug/22 ]

Author:

{'name': 'Gregory Wlodarek', 'email': 'gregory.wlodarek@mongodb.com', 'username': 'GWlodarek'}

Message: SERVER-68925 Reintroduce check table logging settings at startup

(cherry picked from commit 994562a9c82fd89549ac8ee0861eb9f10509d32c)
Branch: v6.1
https://github.com/mongodb/mongo/commit/bc94a2eaade025c799cb6b7aa784d1c8942f04da

Comment by Githook User [ 25/Aug/22 ]

Author:

{'name': 'Gregory Wlodarek', 'email': 'gregory.wlodarek@mongodb.com', 'username': 'GWlodarek'}

Message: SERVER-68925 Reintroduce check table logging settings at startup
Branch: master
https://github.com/mongodb/mongo/commit/994562a9c82fd89549ac8ee0861eb9f10509d32c

Comment by Xiang Gao [ 25/Aug/22 ]

Hi gregory.wlodarek@mongodb.com
Once SERVER-43664 is reverted, how would server react to --setParameter wiredTigerSkipTableLoggingChecksOnStartup=true? I'm asking because there will be customers using older versions of automation agent that still passes this setParameter to start up mongod.

Comment by Dianna Hohensee (Inactive) [ 23/Aug/22 ]

We could consider a startup/setParameter to disable the check+fix, if we want to retain performance. Would have to discuss with Cloud/Atlas. Perhaps OnPrem would be a concern: by default we should perform the check?

Note: we are not sure that SERVER-43664's HELP tickets were caused by table log checking, it could have been oplog sampling, etc.

Generated at Thu Feb 08 06:12:06 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.