[SERVER-69001] Initial sync should set the minValid document to the "stopTimestamp" Created: 19/Aug/22  Updated: 29/Oct/23  Resolved: 16/Sep/22

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 4.2.24, 4.4.19, 5.0.14, 6.0.3, 6.1.0-rc3, 6.2.0-rc0

Type: Bug Priority: Critical - P2
Reporter: Daniel Gottlieb (Inactive) Assignee: Daniel Gottlieb (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Related
related to SERVER-73661 Improve applyOperation_inlock() API. Open
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v6.1
Participants:
Linked BF Score: 25

 Description   

Apologies for the prescriptive solution. matthew.russotto@mongodb.com agreed in thinking this would be the most straight-forward change.

Here's an example of a minvalid check that can happen during initial sync which evaluates the wrong result.

This was found via an unrelated test failure.



 Comments   
Comment by Githook User [ 17/Nov/22 ]

Author:

{'name': 'Daniel Gottlieb', 'email': 'daniel.gottlieb@mongodb.com', 'username': 'dgottlieb'}

Message: SERVER-69001: Have initial sync persist its last oplog time into the minvalid document.

(cherry picked from commit ff2fffdf496ac1bc039cd8c84024cc6159cf80b6)
Branch: v4.2
https://github.com/mongodb/mongo/commit/c8a222bd7cddb738dac52b83bed55d2bddf9363b

Comment by Githook User [ 05/Nov/22 ]

Author:

{'name': 'Daniel Gottlieb', 'email': 'daniel.gottlieb@mongodb.com', 'username': 'dgottlieb'}

Message: SERVER-69001: Have initial sync persist its last oplog time into the minvalid document.

(cherry picked from commit ff2fffdf496ac1bc039cd8c84024cc6159cf80b6)
(cherry picked from commit 14b1ea6d58cf2a2169b2a07268fa2266419703b4)
Branch: v4.4
https://github.com/mongodb/mongo/commit/c66d973949a04a0b80e8bfa7f40e9d2ccf731932

Comment by Githook User [ 03/Nov/22 ]

Author:

{'name': 'Daniel Gottlieb', 'email': 'daniel.gottlieb@mongodb.com', 'username': 'dgottlieb'}

Message: SERVER-69001: Have initial sync persist its last oplog time into the minvalid document.

(cherry picked from commit ff2fffdf496ac1bc039cd8c84024cc6159cf80b6)
(cherry picked from commit 14b1ea6d58cf2a2169b2a07268fa2266419703b4)
Branch: v5.0
https://github.com/mongodb/mongo/commit/ab5364bc82fba17b2347942aac0a8afff9d4ae23

Comment by Githook User [ 01/Nov/22 ]

Author:

{'name': 'Daniel Gottlieb', 'email': 'daniel.gottlieb@mongodb.com', 'username': 'dgottlieb'}

Message: SERVER-69001: Have initial sync persist its last oplog time into the minvalid document.

(cherry picked from commit ff2fffdf496ac1bc039cd8c84024cc6159cf80b6)
(cherry picked from commit 14b1ea6d58cf2a2169b2a07268fa2266419703b4)
Branch: v6.0
https://github.com/mongodb/mongo/commit/b2a4d5da76572a1f820bfd5cd189061cd375d41c

Comment by Githook User [ 21/Sep/22 ]

Author:

{'name': 'Daniel Gottlieb', 'email': 'daniel.gottlieb@mongodb.com', 'username': 'dgottlieb'}

Message: SERVER-69001: Have initial sync persist its last oplog time into the minvalid document.

(cherry picked from commit ff2fffdf496ac1bc039cd8c84024cc6159cf80b6)
Branch: v6.1
https://github.com/mongodb/mongo/commit/14b1ea6d58cf2a2169b2a07268fa2266419703b4

Comment by Githook User [ 15/Sep/22 ]

Author:

{'name': 'Daniel Gottlieb', 'email': 'daniel.gottlieb@mongodb.com', 'username': 'dgottlieb'}

Message: SERVER-69001: Have initial sync persist its last oplog time into the minvalid document.
Branch: master
https://github.com/mongodb/mongo/commit/ff2fffdf496ac1bc039cd8c84024cc6159cf80b6

Comment by Daniel Gottlieb (Inactive) [ 22/Aug/22 ]

Known manifestations are config.image_collection and change stream pre image documents computed from inconsistent initial sync views are accepted when they should rather be invalidated.

Comment by Judah Schvimer [ 22/Aug/22 ]

What is the impact of this bug?

Generated at Thu Feb 08 06:12:20 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.