[SERVER-69063] Fix TCP keepalive option setting Created: 22/Aug/22 Updated: 14/Dec/23 Resolved: 21/Mar/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 7.0.0-rc0, 5.0.24 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Billy Donahue | Assignee: | Billy Donahue |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||||||
| Backport Requested: |
v6.0, v5.0, v4.4
|
||||||||||||||||||||||||
| Sprint: | Service Arch 2022-12-26, Service Arch 2022-09-05, Service Arch 2022-09-19, Service Arch 2022-10-03, Service Arch 2022-10-17, Service Arch 2022-10-31, Service Arch 2022-11-14, Service Arch 2022-11-28, Service Arch 2022-12-12, Service Arch 2023-01-09, Service Arch 2023-01-23, Service Arch 2023-02-06, Service Arch 2023-02-20, Service Arch 2023-03-06, Service Arch 2023-03-20, Service Arch 2023-04-03 | ||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||
| Case: | (copied to CRM) | ||||||||||||||||||||||||
| Description |
|
It seems that I'm looking at this optval variable. Previously it was set to 1 and then overwritten by getsockopt. But in So the setsockopt to configure TCP_KEEPIDLE and TCP_KEEPINTVL never happen. |
| Comments |
| Comment by Githook User [ 14/Dec/23 ] |
|
Author: {'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}Message: GitOrigin-RevId: 41a284c937e2bbc6dd1e505b7e5c3e783325f24b |
| Comment by Githook User [ 21/Mar/23 ] |
|
Author: {'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}Message: |
| Comment by Billy Donahue [ 02/Mar/23 ] |
|
reviving code review and merging current master branch into it. |
| Comment by Billy Donahue [ 25/Aug/22 ] |
|
I think it could be useful to have JUST this fix as a standalone commit. |
| Comment by Billy Donahue [ 22/Aug/22 ] |
|
blake.oler@mongodb.com can you confirm my reading of this code? |