[SERVER-69154] Enable a few non-bug clang-tidy checks Created: 25/Aug/22  Updated: 29/Oct/23  Resolved: 26/Aug/22

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 6.2.0-rc0

Type: New Feature Priority: Major - P3
Reporter: Alex Neben Assignee: Juan Gu
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Problem/Incident
Backwards Compatibility: Fully Compatible
Participants:
Linked BF Score: 165

 Description   

bugprone-bool-pointer-implicit-conversion

bugprone-assert-side-effect

bugprone-copy-constructor-init

bugprone-dangling-handle

bugprone-incorrect-roundings

bugprone-macro-repeated-side-effects
bugprone-misplaced-operator-in-strlen-in-alloc

bugprone-multiple-statement-macro

bugprone-string-integer-assignment

bugprone-suspicious-enum-usage
bugprone-suspicious-memset-usage
bugprone-swapped-arguments

bugprone-terminating-continue

bugprone-undelegated-constructor
hicpp-static-assert
hicpp-undelegated-constructor

modernize-replace-auto-ptr
modernize-replace-random-shuffle

modernize-shrink-to-fit

modernize-unary-static-assert

performance-implicit-conversion-in-loop

performance-inefficient-algorithm



 Comments   
Comment by Britt Snyman [ 01/Sep/22 ]

Replacing the 6.1.0-rc1 fixVersion with 6.2.0-rc0 since these tickets had commits to master that were merged after we branched for v6.1.

Comment by Githook User [ 26/Aug/22 ]

Author:

{'name': 'Juan Gu', 'email': 'juan.gu@mongodb.com'}

Message: SERVER-69154 fix clang tidy issue static_cast(bug BF-26203 is depend on)
Branch: master
https://github.com/mongodb/mongo/commit/79d393bff2838909d85aa7867c710bcf2c34bd9a

Comment by Githook User [ 26/Aug/22 ]

Author:

{'name': 'Alexander Neben', 'email': 'alexander.neben@mongodb.com', 'username': 'IamXander'}

Message: Revert "SERVER-69154 Enable a few more non-bug clang-tidy checks"

This reverts commit 197e01957bc235c50a4eee1bfc1b047a8a987649.
Branch: master
https://github.com/mongodb/mongo/commit/975e47269a0cf27c4781fc69517c74438334d545

Comment by Githook User [ 25/Aug/22 ]

Author:

{'name': 'Juan Gu', 'email': 'juan.gu@mongodb.com'}

Message: SERVER-69154 Enable a few more non-bug clang-tidy checks
Branch: master
https://github.com/mongodb/mongo/commit/197e01957bc235c50a4eee1bfc1b047a8a987649

Comment by Alex Neben [ 25/Aug/22 ]

Copy over a the configurastion from .clang-tidy-extra-checks which is the stuff under `
CheckOptions:`

Generated at Thu Feb 08 06:12:43 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.