[SERVER-6921] jstests/geo_borders.js has several issues Created: 03/Sep/12  Updated: 28/Dec/23

Status: Backlog
Project: Core Server
Component/s: Geo
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: Tad Marshall Assignee: Backlog - Query Integration
Resolution: Unresolved Votes: 0
Labels: qi-geo, query-44-grooming
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to SERVER-4027 Accept geo points equal to 180 (or sp... Closed
is related to SERVER-6918 jstests/geo_borders.js fails verify i... Closed
Assigned Teams:
Query Integration
Participants:

 Description   

jstests/geo_borders.js has some problems:

  • It seems to expect some operations to generate exceptions, but it isn't coded in such a way that those exceptions or the lack of those exceptions are handled properly. The result is that these tests never detect errors.
  • It seems to think that values at the maximum value it used in creating the 2d index will fail lookups, but they do not fail in these tests; the behavior may have changed since these tests were written, but the tests were not updated to account for this.
  • Several tests check the count of found items, but the test passes if any number higher than zero are found, even though there is an exact number that could be tested against. Changes in the count of elements returned by a find will not be detected, and the number returned today may or may not be the correct number.
  • Tests that say (in the comments) that they are testing that a correct point is returned only test the "y" coordinate.
  • If the tests for (apparently) expected exceptions are recoded to detect whether or not an exception is thrown then some of those tests fail. We need to revisit the assumptions about where exceptions are thrown and make the tests pass when the desired behavior is seen.


 Comments   
Comment by Greg Studer [ 03/Sep/12 ]

There was some recently changed behavior which may have affected this test recently added by mathias - the change was to allow values at the high border but store them very slightly reduced from the maximum possible value - SERVER-4027.

geo_full.js is supposed to be a more comprehensive check of geo functionality - though of course any improvements to the test are welcome.

Comment by Tad Marshall [ 03/Sep/12 ]

Code review url: http://codereview.10gen.com/8350014

Generated at Thu Feb 08 03:13:07 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.