[SERVER-69260] [SBE] Improve how optimizeFieldPaths() projects expressions to slots Created: 30/Aug/22  Updated: 29/Oct/23  Resolved: 06/Jan/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 6.3.0-rc0

Type: Task Priority: Major - P3
Reporter: Drew Paroski Assignee: Mihai Andrei
Resolution: Fixed Votes: 0
Labels: auto-reverted, pm2697-m2
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File Capture.PNG    
Issue Links:
Depends
depends on SERVER-60234 Implement plumbing for getField() pus... Closed
Duplicate
is duplicated by SERVER-71993 Coverity analysis defect 134321: Pars... Closed
Problem/Incident
Related
Backwards Compatibility: Fully Compatible
Sprint: QE 2022-10-31, QE 2022-11-14, QE 2022-11-28, QE 2022-12-12, QE 2022-12-26, QE 2023-01-09
Participants:
Linked BF Score: 35
Story Points: 3

 Description   

The goal of this task is to improve how optimizeFieldPaths() projects expressions to slots.

optimizeFieldPaths() is implemented in "src/mongo/db/query/sbe_stage_builder.cpp".



 Comments   
Comment by Githook User [ 06/Jan/23 ]

Author:

{'name': 'Mihai Andrei', 'email': 'mihai.andrei@mongodb.com'}

Message: SERVER-69260 Improve projection of FieldPathExpressions to slots and eliminate redundant project stages in SBE group translation
Branch: master
https://github.com/mongodb/mongo/commit/41301a0e101d90c2be53f4eac6dac89feff0aa44

Comment by xgen-buildbaron-user [ 05/Jan/23 ]

Ticket re-opened due to revert. compile_build_tools_next began a consistent failure of compile_build_tools_next

Comment by Githook User [ 05/Jan/23 ]

Author:

{'name': 'auto-revert-processor', 'email': 'dev-prod-dag@mongodb.com'}

Message: Revert "SERVER-69260 Improve projection of FieldPathExpressions to slots and eliminate redundant project stages in SBE group translation"

This reverts commit 994b658688a884f57c37461c15a356b4eb57bf2b.
Branch: master
https://github.com/mongodb/mongo/commit/b3309f254ed5f110dabc0fa290e710e579cb593b

Comment by Githook User [ 05/Jan/23 ]

Author:

{'name': 'Mihai Andrei', 'email': 'mihai.andrei@mongodb.com'}

Message: SERVER-69260 Improve projection of FieldPathExpressions to slots and eliminate redundant project stages in SBE group translation
Branch: master
https://github.com/mongodb/mongo/commit/994b658688a884f57c37461c15a356b4eb57bf2b

Comment by Kyle Suarez [ 07/Dec/22 ]

FYI mihai.andrei@mongodb.com

Comment by David Storch [ 19/Oct/22 ]

Per discussion this afternoon, I am taking this ticket over from andrew.paroski@mongodb.com. The reason is that this is closely related to $group perf, which I am currently working on, as the optimizeFieldPaths() logic is specific to $group.

CC kyle.suarez@mongodb.com mihai.andrei@mongodb.com

Generated at Thu Feb 08 06:13:01 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.