[SERVER-69383] Improve performance of Decorations Created: 01/Sep/22  Updated: 29/Oct/23  Resolved: 20/Sep/22

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 6.2.0-rc0

Type: Improvement Priority: Major - P3
Reporter: Billy Donahue Assignee: Billy Donahue
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to SERVER-76788 Elide useless constructor calls for t... Closed
Backwards Compatibility: Fully Compatible
Sprint: Service Arch 2022-09-19, Service Arch 2022-10-03
Participants:

 Description   

(generated by SA onsite)
There may be places in the Decoration system that are inefficient in a significant way, particularly the Decorations on OperationContext which are created and destroyed very quickly.

One idea was to elide the invocation of trivial destructor callbacks entirely. Instead of invoking a no-op function pointer, allow it to be nullptr and don't invoke anything.



 Comments   
Comment by Githook User [ 20/Sep/22 ]

Author:

{'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}

Message: SERVER-69383 elide trivial destructors for Decorations
Branch: master
https://github.com/mongodb/mongo/commit/0e99736add3d834bd0094a4f4aac733529a1ad76

Comment by Billy Donahue [ 13/Sep/22 ]

Code Review: https://github.com/10gen/mongo/pull/7285

Comment by Jason Chan [ 12/Sep/22 ]

Prioritizing this because this is also more low hanging fruit for performance gains.

Comment by Billy Donahue [ 01/Sep/22 ]

Draft PoC https://github.com/10gen/mongo/pull/7285
(Struggling a bit to measure this in sys-perf)

Generated at Thu Feb 08 06:13:19 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.