[SERVER-69570] ServiceExecutorSynchronous inefficiencies Created: 09/Sep/22  Updated: 29/Oct/23  Resolved: 22/Sep/22

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 6.2.0-rc0

Type: Improvement Priority: Major - P3
Reporter: Billy Donahue Assignee: Billy Donahue
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Problem/Incident
causes SERVER-73168 diminish the ServiceExecutor benchmar... Closed
Backwards Compatibility: Fully Compatible
Sprint: Service Arch 2022-09-19, Service Arch 2022-10-03
Participants:
Linked BF Score: 21

 Description   

The thread_locals are not great (they're slow in dynamic builds).
There's a deque that's constructed but never used except on worker threads: https://github.com/10gen/mongo/blob/dab0694cd327eb0f7e540de5dee97c69f84ea45d/src/mongo/transport/service_executor_synchronous.cpp#L103

There's another one that's not used at all.

The data members could be more cleanly structured to make this complex class more followable.



 Comments   
Comment by Githook User [ 22/Sep/22 ]

Author:

{'name': 'Billy Donahue', 'email': 'billy.donahue@mongodb.com', 'username': 'BillyDonahue'}

Message: SERVER-69570 ServiceExecutorSynchronous optimizations
Branch: master
https://github.com/mongodb/mongo/commit/25749cbec3d1e8244276a592e3a3dfdb333c061a

Generated at Thu Feb 08 06:13:49 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.