[SERVER-69575] ShardingDataTransformInstanceMetrics Unit Test Suite Does Not Cover Interactions with Cumulative Metrics Created: 09/Sep/22  Updated: 29/Oct/23  Resolved: 27/Sep/22

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: None
Fix Version/s: 6.1.1, 6.2.0-rc0

Type: Bug Priority: Major - P3
Reporter: Brett Nawrocki Assignee: Brett Nawrocki
Resolution: Fixed Votes: 0
Labels: sharding-nyc-subteam1
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v6.1
Sprint: Sharding 2022-09-19, Sharding 2022-10-03
Participants:
Story Points: 2

 Description   

Part of the contract between ShardingDataTransformInstanceMetrics (and its child classes) is that they increment their associated cumulative metrics when certain events happen that the cumulative metrics are interested in tracking. For example, reads during the critical section should increment both the instance metrics counter and the cumulative metrics counter. As seen by the bug that currently exists in those permalinks, our unit test suite does not cover this behavior.

Unit tests should be implemented for all methods in ShardingDataTransformInstanceMetrics and ReshardingMetrics which should update cumulative metrics to be sure that they really do. For example, when a new oplog entry is fetched or when a read comes in during the critical section.



 Comments   
Comment by Githook User [ 11/Oct/22 ]

Author:

{'name': 'Brett Nawrocki', 'email': 'brett.nawrocki@mongodb.com', 'username': 'brettnawrocki'}

Message: SERVER-69575 Add unit tests for SDT instance and cumulative metrics

(cherry picked from commit b7025a4b61e658d1d07c56e057fcc13e792d6fb4)
Branch: v6.1
https://github.com/mongodb/mongo/commit/38a9d526e5dd40e1eb72013a1a9323ab17ea1294

Comment by Githook User [ 26/Sep/22 ]

Author:

{'name': 'Brett Nawrocki', 'email': 'brett.nawrocki@mongodb.com', 'username': 'brettnawrocki'}

Message: SERVER-69575 Add unit tests for SDT instance and cumulative metrics
Branch: master
https://github.com/mongodb/mongo/commit/b7025a4b61e658d1d07c56e057fcc13e792d6fb4

Generated at Thu Feb 08 06:13:50 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.