|
AC:
Collect ninja metrics according to https://docs.google.com/document/d/1_1BwLfERq4mls6RDI8AytPpMWQUK92b-Q1KEQErNPxc/edit#
Evergreen task which ensures that ninja works if metrics collection service is available & unavailable
- We test this extensively via unittests, so this is not needed
Evergreen task to ensure this works with zsh and bash
- zsh and bash are irrelevant now – at the time we thought we might create an alias for a wrapper script to the system ninja installation, but that is not needed since we are using a full-blown python package.
- Evergreen task which ensures no performance regression
- We can add a new Ninja task in evergreen which builds with our new ninja python package, but that would just let us know whether this works or doesn't work – not necessarily perf regressions. For now, we can keep an eye on the new task & old task wall clock time to see if there is anything noticeable. We can also check in with sys-perf to see if there's anything else.
- There's also Ninja Build Profiles: Ubuntu 18.04 which runs a ton of ninja tasks. We could switch that out with the new package and see if there are any perf regressions to ninja that way.
- Have mongo depend on the new ninja package
- Don't forget to update the publish_metrics.py script to publish metrics for the new ninja metrics type
|