[SERVER-69637] Switch to new mongo-ninja-python library Created: 13/Sep/22  Updated: 21/Jan/23  Resolved: 10/Jan/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 6.3.0-rc0

Type: Task Priority: Major - P3
Reporter: Tausif Rahman (Inactive) Assignee: Tausif Rahman (Inactive)
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on SERVER-72349 Create mongo ninja python package Closed
Backwards Compatibility: Fully Compatible
Participants:

 Description   

AC:

  • Collect ninja metrics according to https://docs.google.com/document/d/1_1BwLfERq4mls6RDI8AytPpMWQUK92b-Q1KEQErNPxc/edit#
  • Evergreen task which ensures that ninja works if metrics collection service is available & unavailable
    • We test this extensively via unittests, so this is not needed
  • Evergreen task to ensure this works with zsh and bash
    • zsh and bash are irrelevant now – at the time we thought we might create an alias for a wrapper script to the system ninja installation, but that is not needed since we are using a full-blown python package.
  • Evergreen task which ensures no performance regression
    • We can add a new Ninja task in evergreen which builds with our new ninja python package, but that would just let us know whether this works or doesn't work – not necessarily perf regressions. For now, we can keep an eye on the new task & old task  wall clock time to see if there is anything noticeable. We can also check in with sys-perf to see if there's anything else.
    • There's also Ninja Build Profiles: Ubuntu 18.04 which runs a ton of ninja tasks. We could switch that out with the new package and see if there are any perf regressions to ninja that way.
  • Have mongo depend on the new ninja package
  • Don't forget to update the publish_metrics.py script to publish metrics for the new ninja metrics type


 Comments   
Comment by Githook User [ 10/Jan/23 ]

Author:

{'name': 'Tausif Rahman', 'email': 'tausif.rahman@mongodb.com', 'username': 'trahman1318'}

Message: SERVER-69637 Switch to new mongo-ninja-python library
Branch: master
https://github.com/mongodb/mongo/commit/db6db2824bb9aea2692ae09725a2e4dd16c30a82

Generated at Thu Feb 08 06:13:59 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.