[SERVER-69842] Write gdb pretty-printer test of ABT pretty printers Created: 20/Sep/22 Updated: 29/Oct/23 Resolved: 14/Jul/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 7.1.0-rc0 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Andy Schwerin | Assignee: | Nicholas Zolnierz |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | tech-debt | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Assigned Teams: |
Query Optimization
|
||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||
| Sprint: | QO 2023-07-10, QO 2023-07-24 | ||||||||||||
| Participants: | |||||||||||||
| Description |
|
In [src/mongo/db/query/optimizer/syntax.h, there is a note indicating that the GDB pretty printers should be updated any time a new possible type is added to the definition of ABT. It will soon be possible to write tests of gdb pretty printers, and once it is, we should write one for the ABT pretty printer so we automatically catch regressions and don't have to worry about people reading that comment. |
| Comments |
| Comment by Githook User [ 13/Jul/23 ] |
|
Author: {'name': 'Nicholas Zolnierz', 'email': 'nicholas.zolnierz@mongodb.com', 'username': 'nzolnierzmdb'}Message: |
| Comment by Andy Schwerin [ 21/Sep/22 ] |
|
Oh... That is interesting. That means you cannot pretty-print ABT in a core |
| Comment by Nicholas Zolnierz [ 21/Sep/22 ] |
|
It's worth noting that it may not be trivial to write a unit test for the ABT printers without a running mongod process, since we opted to delegate the actual printing functionality to a C++ function rather than re-implement in python. |
| Comment by Andy Schwerin [ 21/Sep/22 ] |
|
I don’t know. If it’s all right with you, leave it on your backlog in the |
| Comment by Nicholas Zolnierz [ 21/Sep/22 ] |
|
Thanks schwerin@mongodb.com, this will be great. Do you expect |
| Comment by Andy Schwerin [ 20/Sep/22 ] |
|
Likely blocked on |