[SERVER-69926] errorcodes.py doesn't detect duplicate errors in MONGO_UNREACHABLE_TASSERT Created: 22/Sep/22  Updated: 19/Jan/24  Resolved: 14/Oct/22

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 6.1.1, 5.0.14, 6.0.3, 6.2.0-rc0

Type: Bug Priority: Major - P3
Reporter: Mickey Winters Assignee: Reo Kimura (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Related
related to SERVER-85440 Support MONGO_UNIMPLEMENTED_TASSERT i... Closed
Backwards Compatibility: Fully Compatible
Backport Requested:
v6.1, v6.0, v5.0
Sprint: Service Arch 2022-10-17
Participants:

 Description   

goal of this ticket is to fix errorcodes.py and run with --fix. MONGO_UNREACHABLE_TASSERT doesn't exist in 4.4 so this would only need to be backported to 5.0.

here are duplicate errorcodes I found in master after fixing errorcodes.py

DUPLICATE IDS: 6434901
  src/mongo/db/pipeline/document_source.h:650:39:MONGO_UNREACHABLE_TASSERT(6434901
  src/mongo/db/pipeline/pipeline_d.cpp:1449:29:tassert(6434901
DUPLICATE IDS: 5348302
  src/mongo/db/exec/bucket_unpacker.cpp:423:39:MONGO_UNREACHABLE_TASSERT(5348302
  src/mongo/db/pipeline/lite_parsed_pipeline.cpp:196:13:uassert(5348302
DUPLICATE IDS: 5490701
  src/mongo/db/pipeline/window_function/window_function_expression.h:679:35:MONGO_UNREACHABLE_TASSERT(5490701
  src/mongo/db/pipeline/window_function/window_function_expression.h:817:35:MONGO_UNREACHABLE_TASSERT(5490701
  src/mongo/db/pipeline/window_function/window_function_expression.h:865:35:MONGO_UNREACHABLE_TASSERT(5490701
  src/mongo/db/pipeline/window_function/window_function_expression.h:887:35:MONGO_UNREACHABLE_TASSERT(5490701
DUPLICATE IDS: 5490702
  src/mongo/db/pipeline/window_function/window_function_expression.h:683:35:MONGO_UNREACHABLE_TASSERT(5490702
  src/mongo/db/pipeline/window_function/window_function_expression.h:821:35:MONGO_UNREACHABLE_TASSERT(5490702
  src/mongo/db/pipeline/window_function/window_function_expression.h:869:35:MONGO_UNREACHABLE_TASSERT(5490702
  src/mongo/db/pipeline/window_function/window_function_expression.h:891:35:MONGO_UNREACHABLE_TASSERT(5490702
DUPLICATE IDS: 5339900
  src/mongo/db/pipeline/window_function/window_bounds.cpp:93:17:uassert(5339900
  src/mongo/db/query/datetime/date_time_support.cpp:856:31:MONGO_UNREACHABLE_TASSERT(5339900
DUPLICATE IDS: 6273803
  src/mongo/s/commands/cluster_map_reduce_agg.cpp:244:43:MONGO_UNREACHABLE_TASSERT(6273803
  src/mongo/s/query/cluster_aggregate.cpp:504:25:uassert(6273803
MALFORMED ID: 64227002
  src/mongo/db/pipeline/accumulator_sum.cpp:111:39:MONGO_UNREACHABLE_TASSERT(64227002
ok: False 



 Comments   
Comment by Githook User [ 27/Oct/22 ]

Author:

{'name': 'Reo Kimura', 'email': 'reo.kimura@mongodb.com', 'username': 'rkimura21'}

Message: SERVER-69926 errorcodes.py doesn't detect duplicate errors in MONGO_UNREACHABLE_TASSERT

(cherry picked from commit 0d12c83b9b4c3aca1630fc6c41de2f17e4b09ab8)
Branch: v6.0
https://github.com/mongodb/mongo/commit/cd1d537822df6d8508e451fdd68d18017163e0ce

Comment by Githook User [ 27/Oct/22 ]

Author:

{'name': 'Reo Kimura', 'email': 'reo.kimura@mongodb.com', 'username': 'rkimura21'}

Message: SERVER-69926 errorcodes.py doesn't detect duplicate errors in MONGO_UNREACHABLE_TASSERT

(cherry picked from commit 0d12c83b9b4c3aca1630fc6c41de2f17e4b09ab8)
Branch: v6.1
https://github.com/mongodb/mongo/commit/e1199f5b617f87d8dda296031a71f7b9d16dda2d

Comment by Githook User [ 27/Oct/22 ]

Author:

{'name': 'Reo Kimura', 'email': 'reo.kimura@mongodb.com', 'username': 'rkimura21'}

Message: SERVER-69926 errorcodes.py doesn't detect duplicate errors in MONGO_UNREACHABLE_TASSERT

(cherry picked from commit 0d12c83b9b4c3aca1630fc6c41de2f17e4b09ab8)
Branch: v5.0
https://github.com/mongodb/mongo/commit/314b0476d00aa8a5cbbe3114799c07f5939827a2

Comment by Githook User [ 13/Oct/22 ]

Author:

{'name': 'Reo Kimura', 'email': 'reo.kimura@mongodb.com', 'username': 'rkimura21'}

Message: SERVER-69926 errorcodes.py doesn't detect duplicate errors in MONGO_UNREACHABLE_TASSERT
Branch: master
https://github.com/mongodb/mongo/commit/0d12c83b9b4c3aca1630fc6c41de2f17e4b09ab8

Comment by Mickey Winters [ 28/Sep/22 ]

its incomplete I haven't gone and changed all the error codes

Comment by Billy Donahue [ 27/Sep/22 ]

"after fixing errorcodes.py"

Great! So you've already done the fix! Can you send a PR for that?

Generated at Thu Feb 08 06:14:48 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.