[SERVER-69944] Resmoke's globstar.py does not properly parse * before ** Created: 23/Sep/22  Updated: 29/Oct/23  Resolved: 26/Sep/22

Status: Closed
Project: Core Server
Component/s: Testing Infrastructure
Affects Version/s: None
Fix Version/s: 6.1.1, 4.2.24, 4.4.19, 5.0.15, 6.0.4, 6.2.0-rc0

Type: Bug Priority: Major - P3
Reporter: Davis Haupt (Inactive) Assignee: Max Hirschhorn
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Depends
Problem/Incident
causes SERVER-69937 Re-enable skipped tests in Evergreen Closed
Related
is related to SERVER-68301 Enable fle2/query tests in passthroug... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v6.1, v6.0, v5.0, v4.4, v4.2
Steps To Reproduce:

1. Add the path src/mongo/db/modules/*/jstests/fle2/**/*.js to a resmoke suite.
2. Run resmoke.py run --suite=<suite name> --dryRun=tests | grep enterprise/jstests/fle2
3. Results will be empty, but instead should contain the files in the enterprise/jstests/fle2 directory.

Sprint: Sharding 2022-10-03
Participants:
Linked BF Score: 70
Story Points: 2

 Description   

From max.hirschhorn@mongodb.com on Slack:

paths of the form a/*/b/**/c end up attempting to list a literal a/*/b directory instead of trying to glob expand it

honestly python3 has supported globstar since python 3.5 so we should just delete globstar.py



 Comments   
Comment by Githook User [ 12/Dec/22 ]

Author:

{'name': 'Max Hirschhorn', 'email': 'max.hirschhorn@mongodb.com', 'username': 'visemet'}

Message: SERVER-69944 Switch to use Python's built-in recursive glob support.

When splitting a path of the form "a//b/*", globstar.iglob() would
previously have attempted to walk "a/*" as a literal directory instead
of expanding the glob pattern into a list of directories and walking
each of them.
Branch: v4.2
https://github.com/mongodb/mongo/commit/6f7bbce507942f5160b42962b226af9566c08d4b

Comment by Githook User [ 17/Nov/22 ]

Author:

{'name': 'Max Hirschhorn', 'email': 'max.hirschhorn@mongodb.com', 'username': 'visemet'}

Message: SERVER-69944 Switch to use Python's built-in recursive glob support.

When splitting a path of the form "a//b/*", globstar.iglob() would
previously have attempted to walk "a/*" as a literal directory instead
of expanding the glob pattern into a list of directories and walking
each of them.
Branch: v4.4
https://github.com/mongodb/mongo/commit/1787c0fca7ef8de4bc9f20479b2a39fea6d81346

Comment by Githook User [ 17/Nov/22 ]

Author:

{'name': 'Max Hirschhorn', 'email': 'max.hirschhorn@mongodb.com', 'username': 'visemet'}

Message: SERVER-69944 Switch to use Python's built-in recursive glob support.

When splitting a path of the form "a//b/*", globstar.iglob() would
previously have attempted to walk "a/*" as a literal directory instead
of expanding the glob pattern into a list of directories and walking
each of them.
Branch: v5.0
https://github.com/mongodb/mongo/commit/36cbd18d53253fe779c909bb8a33df2742331e89

Comment by Githook User [ 17/Nov/22 ]

Author:

{'name': 'Max Hirschhorn', 'email': 'max.hirschhorn@mongodb.com', 'username': 'visemet'}

Message: SERVER-69944 Switch to use Python's built-in recursive glob support.

When splitting a path of the form "a//b/*", globstar.iglob() would
previously have attempted to walk "a/*" as a literal directory instead
of expanding the glob pattern into a list of directories and walking
each of them.
Branch: v6.0
https://github.com/mongodb/mongo/commit/4c0d9f3d13e5e8f6bf03ec8c22282db03d65eab9

Comment by Githook User [ 16/Nov/22 ]

Author:

{'name': 'Max Hirschhorn', 'email': 'max.hirschhorn@mongodb.com', 'username': 'visemet'}

Message: SERVER-69944 Switch to use Python's built-in recursive glob support.

When splitting a path of the form "a//b/*", globstar.iglob() would
previously have attempted to walk "a/*" as a literal directory instead
of expanding the glob pattern into a list of directories and walking
each of them.
Branch: v6.1
https://github.com/mongodb/mongo/commit/df396f724005fb7011f1b42cb727501a4cfda975

Comment by Githook User [ 26/Sep/22 ]

Author:

{'name': 'Max Hirschhorn', 'email': 'max.hirschhorn@mongodb.com', 'username': 'visemet'}

Message: SERVER-69944 Temporarily disable failing FLE 2.0 tests in multiversion.
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/d49dac3c38081e25904ec34ae73a86cf80ad2d72

Comment by Githook User [ 23/Sep/22 ]

Author:

{'name': 'Max Hirschhorn', 'email': 'max.hirschhorn@mongodb.com', 'username': 'visemet'}

Message: SERVER-69944 Switch to use Python's built-in recursive glob support.

When splitting a path of the form "a//b/*", globstar.iglob() would
previously have attempted to walk "a/*" as a literal directory instead
of expanding the glob pattern into a list of directories and walking
each of them.
Branch: master
https://github.com/mongodb/mongo/commit/6552887793ccf7dc0c52ff7e19167f10990b6567

Comment by Githook User [ 23/Sep/22 ]

Author:

{'name': 'Max Hirschhorn', 'email': 'max.hirschhorn@mongodb.com', 'username': 'visemet'}

Message: SERVER-69944 Temporarily disable failing FLE 2.0 query tests.
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/566bc07ba44cbf0150dc2122b07baadb7acd96a4

Generated at Thu Feb 08 06:14:51 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.