[SERVER-69998] Rename TenantMigrationAccessBlocker public methods Created: 26/Sep/22  Updated: 10/May/23  Resolved: 10/May/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: Christopher Caplinger Assignee: Christopher Caplinger
Resolution: Won't Fix Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Participants:

 Description   

It would be nice to remove any mention of "migration" from TenantMigrationAccessBlocker method names.

For example:

  • TenantMigrationAccessBlockerRegistry => TenantAccessBlockerRegistry
  • getTenantMigrationAccessBlockerForDbName => getAccessBlockerForDbName
  • getTenantMigrationAccessBlockerForTenantId => getAccessBlockerForTenantId

There's also a question about consistency of method names on this class. get is a global helper which returns the decorated value on a serviceContext, so we can't use that name to also return access blockers. On the other hand, we have add/remove/removeAll which don't reference access blockers. We should choose one of these names and make them consistent:

  • addAccessBlockerForTenant
  • addAccessBlockerForTenants
  • addGlobalAccessBlocker
  • getAccessBlockerForTenant
  • removeAccessBlocker
    etc

Finally, we should investigate replacing DonorRecipientAccessBlockerPair with something simpler like:

using DonorRecipientAccessBlockerPair = std::pair<std::shared_ptr, std::shared_ptr>;


Generated at Thu Feb 08 06:15:00 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.