[SERVER-70040] Revert RecordId performance improvement to use shared buffers Created: 28/Sep/22  Updated: 29/Oct/23  Resolved: 04/Nov/22

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 6.2.0-rc0

Type: Task Priority: Major - P3
Reporter: Jordi Olivares Provencio Assignee: Jordi Olivares Provencio
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to SERVER-68081 Investigate performance regression wh... Closed
is related to SERVER-67471 Improve RecordId performance during i... Closed
Backwards Compatibility: Fully Compatible
Sprint: Execution Team 2022-10-31, Execution Team 2022-11-14
Participants:

 Description   

With SERVER-67471 we made some changes to RecordId in order to fix a regression we detected with our internal performance benchmarks. The fix made was to use unique buffers instead of shared buffers for large record ids as that made the regression go away.

In SERVER-68081 we discovered that this regression was only detected in the CPU used in our benchmarks and is not present in current CPUs.

The purpose of this ticket is to revert the unique buffer and go back to using shared buffers for large record ids.



 Comments   
Comment by Githook User [ 04/Nov/22 ]

Author:

{'name': 'Jordi Olivares Provencio', 'email': 'jordi.olivares-provencio@mongodb.com', 'username': 'jordiolivares'}

Message: SERVER-70040 Revert RecordId unique buffer to use shared buffer
Branch: master
https://github.com/mongodb/mongo/commit/05427d82a4846dd07e19d9ea772c48111e1d84a5

Comment by Andy Schwerin [ 04/Oct/22 ]

Ooh, this might be a good opportunity to try to write a simple GDB pretty printer test if the infrastructure is in place. if it isn't please file a ticket and block it on SERVER-69843.

Comment by Louis Williams [ 04/Oct/22 ]

Don't forget about the GDB pretty-printers

Comment by Jordi Olivares Provencio [ 28/Sep/22 ]

CC schwerin@mongodb.com

Generated at Thu Feb 08 06:15:06 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.