[SERVER-70126] Get rid of the syncFromConfig argument of the internal command to flush the routing table cache Created: 30/Sep/22 Updated: 19/Oct/22 Resolved: 19/Oct/22 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Antonio Fuschetto | Assignee: | Antonio Fuschetto |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Sprint: | Sharding EMEA 2022-10-17, Sharding EMEA 2022-10-31 |
| Participants: |
| Description |
|
Based on analysis that includes old versions down to 4.0 (latest unsupported version), the syncFromConfig argument of the _flushRoutingTableCacheUpdates command is never set to false. Consequently, all the related logic when set to false can be eliminated. Goal of this task is to evaluate that statement and possibly get rig of the related logic. Based on an analysis that includes older versions up to 4.0 (latest version not supported), the syncFromConfig argument of the _flushRoutingTableCacheUpdates command is never set to false. As a result, all related logic when set to false can be removed. The goal of this task is to evaluate that statement, possibly remove the argument and change the related logic assuming it is always true. Open questions: |
| Comments |
| Comment by Antonio Fuschetto [ 19/Oct/22 ] |
|
In 8 occurrences, the Sharding team suggested to the TSE team to explicitly set the syncFromConfig argument to true (although it was not necessary as it is already the default value). By removing this argument, the risk is that any other invocation that explicitly passes this argument would cause the command to fail since it's `strict: true`. As there is not a great value in removing this argument, but for sure there is a limited risk of a breaking change, is preferable to reject the ticket. |