[SERVER-70202] Investigate calling serverGlobalParams.featureCompatibility.isVersionInitialized() in isEnabled() Created: 04/Oct/22  Updated: 02/Nov/23  Resolved: 26/Apr/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.1.0-rc0

Type: Task Priority: Major - P3
Reporter: Huayu Ouyang Assignee: Jiawei Yang
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to SERVER-79274 FCV checks can be racy if FCV is unin... Closed
related to SERVER-79269 Invariant that we don't check FCV in ... Open
related to SERVER-79183 [v7.0] Add check if fcv is initialize... Closed
related to SERVER-76575 Check isVersionInitialized() within F... Closed
related to SERVER-80901 Audit gFeatureFlagServerlessChangeStr... Closed
Assigned Teams:
Replication
Backwards Compatibility: Fully Compatible
Sprint: Repl 2023-05-01
Participants:

 Description   

Currently FeatureFlag::isEnabled() does not check if serverGlobalParams.featureCompatibility.isVersionInitialized(), but in many places throughout the codebase the caller needs to check this (i.e. serverGlobalParams.featureCompatibility.isVersionInitialized() &&
gFeatureFlagRequireTenantID.isEnabled(serverGlobalParams.featureCompatibility))

We should investigate if we should always be calling this and can move it into isEnabled()

Edit: SERVER-66482 created isEnabledUseDefaultFCVWhenUninitialized so we should audit usages of isEnabled and see if we can use isEnabledUseDefaultFCVWhenUninitialized instead.



 Comments   
Comment by Githook User [ 25/Apr/23 ]

Author:

{'name': 'Jiawei Yang', 'email': 'jiawei.yang@mongodb.com', 'username': 'YoungYang0820'}

Message: SERVER-70202 move fcv initialization check into featureFlag::isEnabled()
Branch: master
https://github.com/mongodb/mongo/commit/27a8e30e8aa02d3f3be35630b970c7b903d1d186

Comment by Huayu Ouyang [ 21/Feb/23 ]

May be done in SERVER-66482

Generated at Thu Feb 08 06:15:33 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.