[SERVER-70252] Tag additional plan cache related tests as 'tenant_migration_incompatible' Created: 05/Oct/22 Updated: 29/Oct/23 Resolved: 17/Oct/22 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 6.2.0-rc0 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | David Storch | Assignee: | Mathis Bessa |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||
| Sprint: | Server Serverless 2022-10-17, Server Serverless 2022-10-31 | ||||||||||||
| Participants: | |||||||||||||
| Linked BF Score: | 35 | ||||||||||||
| Description |
|
In
And then running the test under the tenant_migration_jscore_passthrough suite with a command like this:
The solution was to tag the test as "tenant_migration_incompatible". Since the plan cache state is local to a particular mongod node, any plan cache test that explicitly interrogates the plan cache using something like $planCacheStats could hypothetically fail in the tenant migration, shard split, or shard merge passthroughs. The test could generate some mongod-local plan cache state, but then if a tenant migration commits, the test will begin communicating with a new node that has a cold plan cache without the expected state. The work for this ticket is to identify plan cache tests which 1) are currently running the tenant migration, shard merge, or shard split passthroughs, and 2) which we believe could fail in these passthroughs if a tenant migration committed at an inopportune time. Any such test should be tagged "tenant_migration_incompatible" to prevent future build failures. With a quick search using the build baron tool, I did find a couple BFGs that might fit under the above rubric:
|
| Comments |
| Comment by Githook User [ 17/Oct/22 ] |
|
Author: {'name': 'mathisbessamdb', 'email': 'mathis.bessa@mongodb.com', 'username': 'mathisbessamdb'}Message: |
| Comment by Mathis Bessa [ 10/Oct/22 ] |
|
The test that was failing has already been fixed in The tests are already marked as "does_not_support_stepdowns" which is not sufficient for tenant_migration_passthroughs (and other migration passthrough such as shard_merge and shard_split) therefore we need to be consistent and mark other tests "tenant_migration_incompatible" as well. |
| Comment by Steven Vannelli [ 10/Oct/22 ] |
|
Thanks for the ticket david.storch@mongodb.com. We're going to put this in the backlog for now since the immediate BF has been resolved. If this requires sooner attention, let us know. mathis.bessa@mongodb.com to add some more context on this ticket. |