[SERVER-70295] Build collMod unit tests that work with gFeatureFlagRequireTenantID=false Created: 06/Oct/22 Updated: 12/Jul/23 Resolved: 30/Mar/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Hugh Tong (Inactive) | Assignee: | [DO NOT USE] Backlog - Server Serverless (Inactive) |
| Resolution: | Won't Do | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Assigned Teams: |
Serverless
|
||||||||
| Participants: | |||||||||
| Description |
|
We are building tests for collMod in op_applier_impl_test.cpp, and while this works for the cases where gFeatureFlagRequireTenantID=true, this doesn't currently work for gFeatureFlagRequireTenantID=false because the CollMod::parse() function builds the _dbName object first, then uses this to build the _nss object. This means we don't benefit from the gFeatureFlagRequireTenantID-sensitive serializr/deserializer functions, and the tenantId remains prefixed onto the dbstring. Either a change to how the collMod parser idl is defined is needed, or we need to add DatabaseName serializer/deserializer functions. We should be able to use the existing collMod test as a template once this is complete. |
| Comments |
| Comment by Githook User [ 12/Jul/23 ] |
|
Author: {'name': 'Sophia Tan', 'email': 'sophia_tll@hotmail.com', 'username': 'sophiatll'}Message: |