[SERVER-70332] Decide value and act on windows non all feature flags variant Created: 07/Oct/22  Updated: 29/Oct/23  Resolved: 31/Oct/22

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 6.2.0-rc0

Type: Task Priority: Major - P3
Reporter: Alex Neben Assignee: Alex Neben
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Participants:

 Description   

Value includes
1. Cost to run (computed from SERVER-70331)
2. BFs uniquely caught (computed via looking at Jira tags)

Paths foward include
1. Do nothing
2. Remove as required variant
3. Remove as required variant and drop down testing to daily
4. Remove as required variant and drop down testing even lower than daily

UPDATE:
Based on investigation these should be moved to run once a day and combined in a single PR with SERVER-70333

Note that the tests do not have 100% overlap and we need to support the union



 Comments   
Comment by Githook User [ 31/Oct/22 ]

Author:

{'name': 'Alexander Neben', 'email': 'alexander.neben@mongodb.com', 'username': 'IamXander'}

Message: SERVER-70332 SERVER-70333 Reduced load on our patch builds
Branch: master
https://github.com/mongodb/mongo/commit/d6606b87b8dd870d0c295b1213febe636c678b6f

Comment by Robert Guo (Inactive) [ 12/Oct/22 ]

Agreed. None of the failures look unique to the default Windows required variant.

Moving the freed up compute hours over to the all feature flag Windows variant sounds great to me.

max.hirschhorn@mongodb.com any concerns on your end?

Comment by Alex Neben [ 12/Oct/22 ]

Using this filter I have found 4 issues since Jan 1 2021 that would have been caught by this variant. However, not all of these are deterministic so they could have still made it into mainline but they were not caught by any other required variants. Make sure to ignore issues that have the label not_unqiue_to_variant. Based on these results I would like to enable tests that are part of windows no feature flags into all feature flags AND move no feature flag windows variant to be a daily cron rather than a required variant.

Thoughts?
CC max.hirschhorn@mongodb.com /robert.guo@mongodb.com 

Generated at Thu Feb 08 06:15:53 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.