[SERVER-70715] Add additional compilation tests for windows Created: 19/Oct/22  Updated: 29/Oct/23  Resolved: 22/Aug/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.1.0-rc0

Type: Improvement Priority: Major - P3
Reporter: Alex Neben Assignee: Zack Winter
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Assigned Teams:
Server Development Platform
Backwards Compatibility: Fully Compatible
Participants:

 Description   

https://github.com/10gen/mongo/commit/36194c546281d6a10b003bf3cd12f771ff268c50
The following commit passed windows builds that should have been caught. We need to create additional tests that represent how people are building on windows. I think we are already covered with ninja but doing a hello world build with some different flags / options would cut down on windows build failures. This should include testing for a variety of options that are commonly used by people building scons/ninja on windows.

Should build scons/ninja with combination of dbg=on/off, opt=on/off. daniel.moody@mongodb.com might have some more ideas?

https://mongodb.slack.com/archives/CR8SNBY0N/p1665592426555899?thread_ts=1665589655.149649&cid=CR8SNBY0N



 Comments   
Comment by Githook User [ 22/Aug/23 ]

Author:

{'name': 'Zack Winter', 'email': 'zack.winter@mongodb.com', 'username': 'zackwintermdb'}

Message: SERVER-70715 Add dev compilation tests for windows
Branch: master
https://github.com/mongodb/mongo/commit/67a8627cbc91078f46e5826a1b8f3c1a5717f453

Comment by Alex Neben [ 15/Aug/23 ]

I actually think that is the perfect place to start. To answer your question we do not record compilations on windows so we don't have that info

Comment by Zack Winter [ 15/Aug/23 ]

alex.neben@mongodb.com do we collect locally run compilation commands in a database anywhere? Otherwise is there a good place to ask for common setups windows compilation? I see there's a windows slack channel I could start there.

I see that the original motivation for this was  `python buildscripts\scons.py --ninja build.ninja --opt=off --dbg=on` failing. I can just run 4 different hello world builds with a combination of opt/dbg on/off, but I'd imagine there's more we want to test for.
 

Generated at Thu Feb 08 06:16:55 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.