[SERVER-70821] Rename RecoveryUnit::getPointInTimeReadTimestamp Created: 24/Oct/22  Updated: 05/Dec/22

Status: Backlog
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: Matthew Saltz (Inactive) Assignee: Backlog - Storage Execution Team
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Assigned Teams:
Storage Execution
Participants:

 Description   

As a newcomer to this code, I was reading callsites of RecoveryUnit::getPointInTimeReadTimestamp, like this one as if it were a normal getter function - one with no side effects that just returned the read timestamp. But it turns out that it actually opens a storage transaction in some cases!

That was unexpected. In addition there are other usages like here where I wonder if the author knew that this was an anticipated side effect. Personally, I would not have expected this line to sometimes open a snapshot.

Renaming this function something like establishPointInTimeReadTimestamp or something that sounded less like a passive getter might make this behavior less surprising to future users/readers.


Generated at Thu Feb 08 06:17:13 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.