[SERVER-70865] TicketHolder counters are not always reported as 64 bit integers Created: 26/Oct/22  Updated: 29/Oct/23  Resolved: 16/Feb/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.0.0-rc0

Type: Task Priority: Major - P3
Reporter: Haley Connelly Assignee: Haley Connelly
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Problem/Incident
Backwards Compatibility: Fully Compatible
Sprint: Execution Team 2022-12-12, Execution Team 2022-11-28, Execution Team 2023-02-20, Execution Team 2023-01-23, Execution Team 2023-02-06
Participants:
Linked BF Score: 135

 Description   

Confirm that all necessary counters are 64 bit integers or change them to be 64 bit integers.



 Comments   
Comment by Githook User [ 16/Feb/23 ]

Author:

{'name': 'Haley Connelly', 'email': 'haley.connelly@mongodb.com', 'username': 'haleyConnelly'}

Message: SERVER-70865 Add size precision to ints in TicketHolder code
Branch: master
https://github.com/mongodb/mongo/commit/7ce86e0097ec60b13a6cdb127422189ce5ec2bf5

Comment by Haley Connelly [ 06/Feb/23 ]

I've held off on this a little since there was a discovery it may not have been our original commit which caused the regression. After discussing it with the team members, I think it is still reasonable to have everything be int32_t

Comment by Haley Connelly [ 25/Jan/23 ]

This is a really good point. I'm not opposed to this.

Comment by Gregory Noma [ 24/Jan/23 ]

haley.connelly@mongodb.com would we consider using int32_t so that we're at least being precise about the integer width we want?

Comment by Githook User [ 24/Jan/23 ]

Author:

{'name': 'Haley Connelly', 'email': 'haley.connelly@mongodb.com', 'username': 'haleyConnelly'}

Message: Revert "SERVER-70865 Make TicketHolder's queued() counter int64_t"

This reverts commit 053984fd853e1900c4558006d2ed577789648142.
Branch: master
https://github.com/mongodb/mongo/commit/8dc2b488b02da893742bd818b8d8c497a9eaec71

Comment by Haley Connelly [ 24/Jan/23 ]

After further consideration, and a potential performance regression, we've decided to revert this commit. queued() is at some point limited by the OS with respect to the number of connections allowed, and if we are handling > 2,147,483,647 connections, there will likely be other issues going on with the mongod.

Comment by Githook User [ 23/Jan/23 ]

Author:

{'name': 'Haley Connelly', 'email': 'haley.connelly@mongodb.com', 'username': 'haleyConnelly'}

Message: SERVER-70865 Make TicketHolder's queued() counter int64_t
Branch: master
https://github.com/mongodb/mongo/commit/053984fd853e1900c4558006d2ed577789648142

Comment by Haley Connelly [ 11/Jan/23 ]

This is still waiting on the TicketBroker to be integrated into the PriorityTicketHolder in SERVER-72072

Generated at Thu Feb 08 06:17:21 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.