[SERVER-70878] Decide value and act on linux-64-debug-required build variant Created: 26/Oct/22  Updated: 29/Jul/23  Resolved: 18/Jul/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: Alex Neben Assignee: Trevor Guidry
Resolution: Duplicate Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to SERVER-79037 Replace windows required variant with... Open
related to SERVER-79035 Add missing tests to the aubsan all f... Backlog
related to SERVER-79036 Replace community required variant wi... Backlog
Assigned Teams:
Server Development Platform
Participants:

 Description   

Value includes
1. Cost to run (computed from SERVER-70331)
2. BFs uniquely caught (computed via looking at Jira tags)

Paths forward include
1. Do nothing
2. Remove as required variant
3. Remove as required variant and drop down testing to daily
4. Remove as required variant and drop down testing even lower than daily

EDIT: I think we will want to replace this one with asan/ubsan variant.
EDIT 2: I think replacing this one with aubsan would be incorrect since we are not running the all feature flags version on this variant.



 Comments   
Comment by Alex Neben [ 10/Apr/23 ]

We are going with this depending on cost (pending makespan and cost)

required:

(all_feature_flags=on, dbg=on, opt=on, OS=x, tests=all, arch=X, aubsan=on)
(all_feature_flags=off, dbg=off, opt=on, OS=x, tests=all, arch=X)
(all_feature_flags=on, dbg=off, opt=on, OS=x, tests=all, arch=X)
(all_feature_flags=on, dbg=off, opt=on, OS=windows, tests=sharding_jscore + unittests, arch=x86_64)

suggested:
(all_feature_flags=on, dbg=off, opt=on, OS=windows, tests=all, arch=x86_64)
(all_feature_flags=on, dbg=on, opt=on, community=on, OS=rhel80, tests=all, arch=x86_64)

Get cost

Comment by Alex Neben [ 24/Mar/23 ]

From 1-1 with Max
Max: Most new code being written is under feature flags so we should be testing that. Worried that if we only test with dbg=on we will start to miss ones with dbg=off. Patch build debug=on feature-flags=off is not needed. alexander.neben@mongodb.com is going to come back with more data. Maybe we want to separate out randomness for also running with debug off.

Comment by Alex Neben [ 22/Feb/23 ]

According to this query it looks like there might be quite a few BFs unique to this required variant. We need to involve server engineers to see if the tradeoff is worth it. Things caught in this variant will be caught later on but that might be post merge.

 

Another option is to try and remove tasks from this variant to slim down the cost.

 

Any thoughts on this max.hirschhorn@mongodb.com ? (Not high priority)

 

https://jira.mongodb.org/browse/BF-27630?jql=(cf%5B14277%5D%20%3D%20linux-64-debug-required%20and%20cf%5B14278%5D%20%3D%20mongodb-mongo-master)%20AND%20cf%5B14277%5D%20!%3D%20enterprise-rhel-80-64-bit-dynamic-all-feature-flags-required%20AND%20cf%5B14277%5D%20!%3D%20%20enterprise-windows-all-feature-flags-required%20ORDER%20BY%20created%20DESC

Generated at Thu Feb 08 06:17:23 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.