[SERVER-70895] Consider reordering arguments to async_rpc::sendCommand functions Created: 27/Oct/22 Updated: 29/Oct/23 Resolved: 11/Sep/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 7.2.0-rc0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | George Wangensteen | Assignee: | Erin McNulty |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | neweng | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Assigned Teams: |
Service Arch
|
| Backwards Compatibility: | Fully Compatible |
| Sprint: | Service Arch 2023-09-04, Service Arch 2023-09-18 |
| Participants: |
| Description |
|
Existing PrimaryOnlyService implementations have created some existing calling-conventoins for async APIs that take in executors as work-contexts and CancellationTokens for cancellation. Additionally, the server has some best practices around ordering different types of arguments (pointer vs reference vs optional). We should change the argument ordering for sendCommand to match these conventions and expectations. |
| Comments |
| Comment by Githook User [ 11/Sep/23 ] |
|
Author: {'name': 'Erin McNulty', 'email': 'erin.mcnulty@mongodb.com', 'username': 'erin2722'}Message: |