[SERVER-71029] Update slow SessionWorkflow log criteria Created: 02/Nov/22 Updated: 29/Oct/23 Resolved: 29/Nov/22 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 6.3.0-rc0 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Matt Diener (Inactive) | Assignee: | Blake Oler |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||||||||||
| Operating System: | ALL | ||||||||||||||||||||||||||||
| Backport Requested: |
v6.2
|
||||||||||||||||||||||||||||
| Sprint: | Service Arch 2022-11-14, Service Arch 2022-11-28, Service Arch 2022-12-12 | ||||||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||||||
| Linked BF Score: | 105 | ||||||||||||||||||||||||||||
| Description |
|
The Slow SessionWorkflow log in session_workflow.cpp currently logs based on what it deems "active time". This is effectively all time that is not waiting for a message to be received. It turns out that a lot of this active time can be time that the Slow Query log does not count, causing the SessionWorkflow log to happen way too often, introducing a performance regression (BF-26754). Given that our criteria isn't as nuanced as it should be, and this layer of the system does not have access to the data required to make such a nuanced decision, we should revert back to the intention of this bug and simply log when `sendResponseMillis > slowMS`. The log message itself should change and the test for the Slow SessionWorkflow log should be updated (slow_session_workflow_log.js). |
| Comments |
| Comment by Githook User [ 28/Nov/22 ] |
|
Author: {'name': 'Blake Oler', 'email': 'blake.oler@mongodb.com', 'username': 'BlakeIsBlake'}Message: |