[SERVER-71099] Remove Session Tags and Cleanup Egress Tag Closer Created: 04/Nov/22 Updated: 29/Oct/23 Resolved: 03/Oct/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 7.2.0-rc0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Matt Diener (Inactive) | Assignee: | Alex Li |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||
| Assigned Teams: |
Service Arch
|
||||||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||||||
| Sprint: | Service Arch 2022-12-26, Service Arch 2022-11-28, Service Arch 2022-12-12, Service Arch 2023-01-09, Service Arch 2023-07-10, Service Arch 2023-07-24, Service Arch 2023-08-07, Service Arch 2023-08-21 | ||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||
| Description |
|
Design doc: https://docs.google.com/document/d/1Z5KwY7B-ck8pmea0S7y8ak6y7F5FuF3cP1uLMmTx_r8/ The tags attached to sessions describe clients. This is a layering violation. The main context where we care about tags is in situations where we’re closing collections of Sessions or asking the Session about a property of its associated client in ingress code paths. We should re-introduce the tags to the Client and handle `kKeepOpen` and `kPending` appropriately for both Client and AsyncClient. If only one tag is possible at a time after these changes, we should assess whether these tags ought to be replaced by an enum. |