[SERVER-71100] Make Session diagnostics logging generic Created: 04/Nov/22  Updated: 29/Oct/23  Resolved: 21/Sep/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.2.0-rc0

Type: Improvement Priority: Major - P3
Reporter: Matt Diener (Inactive) Assignee: Alex Li
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on SERVER-71909 Split ASIOSession into a Sync and an ... Closed
Assigned Teams:
Service Arch
Backwards Compatibility: Fully Compatible
Sprint: Service Arch 2022-12-26, Service Arch 2022-11-14, Service Arch 2022-11-28, Service Arch 2022-12-12, Service Arch 2023-01-09, Service Arch 2023-01-23, Service Arch 2023-02-06, Service Arch 2023-06-12, Service Arch 2023-06-26, Service Arch 2023-07-10, Service Arch 2023-07-24, Service Arch 2023-08-07, Service Arch 2023-09-04, Service Arch 2023-09-18, Service Arch 2023-10-02
Participants:

 Description   

Design doc: https://docs.google.com/document/d/1Z5KwY7B-ck8pmea0S7y8ak6y7F5FuF3cP1uLMmTx_r8 

Information provided by the Session to logs is likely to differ between ASIO and gRPC sessions. Instead of systems pulling details from Session in a Session-aware way, these subsystems should be able to call appendBSONForDiagnostics(BSONObjBuilder& bb), or something similar, without having to worry about the underlying Session implementation.

In the process, we should remove:

  • HostAndPort& remote()
  • HostAndPort& local()
  • SockAddr& remoteAddr(); if possible
  • SockAddr& localAddr(); if possible

If there is some large project blocking us from removing remoteAddr and localAddr, we should log the corresponding follow-up work (this is a last resort and we reach out to the Security team for help resolving any challenges).



 Comments   
Comment by Githook User [ 20/Sep/23 ]

Author:

{'name': 'Alex Li', 'email': 'alex.li@mongodb.com', 'username': 'lia394126'}

Message: SERVER-71100 Make Session diagnostics logging generic
Branch: master
https://github.com/mongodb/mongo/commit/da9a1ea2512eccf8c5f38c648c42a5bbb48a8055

Generated at Thu Feb 08 06:18:03 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.