[SERVER-71127] Audit buildXXX() methods in SBE stage builder for handling of kReturnKey Created: 07/Nov/22 Updated: 10/Jan/23 Resolved: 10/Jan/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Drew Paroski | Assignee: | Backlog - Query Execution |
| Resolution: | Won't Do | Votes: | 0 |
| Labels: | pm2697-m4 | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Assigned Teams: |
Query Execution
|
| Participants: |
| Description |
|
The goals of this task are to: 1) Improve our testing of the "returnKey()" feature in SBE a little so that we have better coverage for the kReturnKey req propagating to various buildXXX() methods in "sbe_stage_builder.cpp"; 2) Identify the buildXXX() methods that don't handle kReturnKey and don't assert that "reqs.has(ReturnKey)" is false, and for each method decide whether it should support kReturnKey or whether it should assert that "reqs.has(ReturnKey)" is false. |
| Comments |
| Comment by Mihai Andrei [ 10/Jan/23 ] |
|
Per offline discussion, we determined that this ticket is not worth doing. |