[SERVER-71130] lint-sconslinters gives bad advice about how to fix lint issues Created: 07/Nov/22 Updated: 05/Dec/22 Resolved: 07/Nov/22 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | George Wangensteen | Assignee: | [DO NOT ASSIGN] Backlog - Server Development Platform Team (SDP) (Inactive) |
| Resolution: | Duplicate | Votes: | 1 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Assigned Teams: |
Server Development Platform
|
||||||||
| Operating System: | ALL | ||||||||
| Participants: | |||||||||
| Description |
|
When SCons linting fails, the linter gives bad advice about how to fix the issue; it says: To fix formatting errors, run pylinters.py fix <path to file> But this won't work, as I learned through trial-and-error. In fact, you need to run pylinters.py fix-scons <optional path to file> to fix the issue (similarly, you need to do lint-scons rather than just lint to see lint failures for SConscripts). |
| Comments |
| Comment by George Wangensteen [ 07/Nov/22 ] |
|
daniel.moody@mongodb.com my branch did not contain the commit from the linked ticket when I first encountered the issue. It looks like on master branch, failing lint-scons gives the correct advice to use fix-scons. I'll close this ticket as a dupe, thanks! |