[SERVER-71187] Index Build Coordinator to use TenantId object instead of StringData Created: 08/Nov/22  Updated: 29/Oct/23  Resolved: 09/Dec/22

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 6.3.0-rc0

Type: Task Priority: Major - P3
Reporter: Mathis Bessa Assignee: Mathis Bessa
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Problem/Incident
Related
related to SERVER-70027 Use TenantId object instead of String... Closed
related to SERVER-70913 Investigate changes needed to ShardSp... Closed
related to SERVER-71669 Remove TODO to no longer use StringDa... Closed
Backwards Compatibility: Fully Compatible
Sprint: Server Serverless 2022-12-12
Participants:
Linked BF Score: 0

 Description   

We should make changes to the index_build_coordinator to support using TenantId objects. Most of the work seems to be done within the methods however we should still pass a TenantId object instead of a StringData.
 
abortTenantIndexBuilds is still a StringData when calling ClonerUtils::isDatabaseForTenant which will be addressed in SERVER-70027 which should be done once SERVER-71187 is merged to master.

We are also going to use SERVER-71669 to clean-up some method that had to be re-defined (instead of replaced) to use a TenantId object. Part of that ticket will be to remove the old methods (still using StringData) to leave room for only using the TenantId methods once the tenant migration code switches to using only TenantId objects.



 Comments   
Comment by Githook User [ 09/Dec/22 ]

Author:

{'name': 'mathisbessamdb', 'email': 'mathis.bessa@mongodb.com', 'username': 'mathisbessamdb'}

Message: SERVER-71187 Index Build Coordinator to use TenantId object instead of StringData
Branch: master
https://github.com/mongodb/mongo/commit/3f8202cdeba4723fffb5f456f1d42921168cc15c

Comment by Githook User [ 07/Dec/22 ]

Author:

{'name': 'mathisbessamdb', 'email': 'mathis.bessa@mongodb.com', 'username': 'mathisbessamdb'}

Message: Revert "SERVER-71187 Index Build Coordinator to use TenantId object instead of StringData"

This reverts commit 5c403f99e17fd1d8989f05afd9109f52897e2856.
Branch: master
https://github.com/mongodb/mongo/commit/a21da305144e91529eed6e75b39e12329a9c703f

Comment by Mathis Bessa [ 07/Dec/22 ]

Re-opening this since it's causing failures on master.

Comment by Githook User [ 07/Dec/22 ]

Author:

{'name': 'mathisbessamdb', 'email': 'mathis.bessa@mongodb.com', 'username': 'mathisbessamdb'}

Message: SERVER-71187 Index Build Coordinator to use TenantId object instead of StringData
Branch: master
https://github.com/mongodb/mongo/commit/5c403f99e17fd1d8989f05afd9109f52897e2856

Generated at Thu Feb 08 06:18:17 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.