[SERVER-71210] move packTransactionStatementsForApplyOps() from OpObserverImpl to TransactionOperations Created: 09/Nov/22  Updated: 29/Oct/23  Resolved: 16/Nov/22

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 6.2.0-rc0, 6.3.0-rc0

Type: Task Priority: Major - P3
Reporter: Benety Goh Assignee: Benety Goh
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to SERVER-70899 move logOplogEntries() from OpObserve... Closed
Backwards Compatibility: Fully Compatible
Sprint: Execution Team 2022-11-14, Execution Team 2022-11-28
Participants:

 Description   

This is prerequisite for moving logOplogEntries() in SERVER-70899. We will also clarify some of the const (or lack of) qualifiers in OpObserver::onTransactionPrepare() and logOplogEntries; as well as some of the optional parameters that we always provide values for.



 Comments   
Comment by Githook User [ 15/Nov/22 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-71210 move packTransactionStatementsForApplyOps() from op_observer_impl.cpp to TransactionOperations
Branch: master
https://github.com/mongodb/mongo/commit/c0c21c9491d117ce4353511b05d1381205889e3b

Comment by Githook User [ 15/Nov/22 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-71210 OpObserver::onTransactionPrepare() accepts const statements and applyOps info
Branch: master
https://github.com/mongodb/mongo/commit/819c3c931e4a120342d01b8eb5cbc4a189e29e87

Comment by Githook User [ 15/Nov/22 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-71210 OpObserver::onTransactionPrepare() accepts const statements and applyOps info
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/17a664de1f7587847574e86afaf9586ece2861e5

Comment by Githook User [ 15/Nov/22 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-71210 ensure logOplogEntries does not modify provided repl ops
Branch: master
https://github.com/mongodb/mongo/commit/d6fd343123451105dfc04cab71db334cae871e6f

Comment by Githook User [ 15/Nov/22 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-71210 annotate logApplyOps() parameters in OpObserverImpl::onTransactionPrepare()
Branch: master
https://github.com/mongodb/mongo/commit/113191f7267e4ee814216305d919d3589349ba87

Comment by Githook User [ 15/Nov/22 ]

Author:

{'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}

Message: SERVER-71210 logApplyOps() always gets a non-optional txnState

Last optional instances of this parameter were removed in commit ebfc0dc2e6f80e61d6b94742a79d1194997a7959.
Branch: master
https://github.com/mongodb/mongo/commit/366cc6008917a221ed1b90a2c2b339702b943889

Generated at Thu Feb 08 06:18:21 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.