[SERVER-71237] Add shared golden unit test fixture for ABT tests Created: 10/Nov/22  Updated: 29/Oct/23  Resolved: 08/Dec/22

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 6.2.0-rc0, 6.3.0-rc0

Type: Improvement Priority: Major - P3
Reporter: Nicholas Zolnierz Assignee: Nicholas Zolnierz
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Assigned Teams:
Query Optimization
Backwards Compatibility: Fully Compatible
Sprint: QO 2022-11-14, QO 2022-11-28, QO 2022-12-12
Participants:

 Comments   
Comment by Githook User [ 07/Dec/22 ]

Author:

{'name': 'Nicholas Zolnierz', 'email': 'nicholas.zolnierz@mongodb.com', 'username': 'nzolnierzmdb'}

Message: SERVER-71237 Refactor ABT golden tests to use a shared fixture and de-duplicate several test helper functions
Branch: master
https://github.com/mongodb/mongo/commit/1acfc08bc6594abe87f8b55a5e6aa4194251d5b5

Comment by Nicholas Zolnierz [ 07/Dec/22 ]

Refactoring this ticket to an improvement on the ABT golden unit tests that should help some of the legibility. Note that there was some prior work on debugging golden test failures by https://github.com/mongodb/mongo/commit/2bc320ca782cd7f7759d8734ee3c29bcc0af9a47 which alleviates most of the need for the original goal of this ticket.

Comment by Githook User [ 14/Nov/22 ]

Author:

{'name': 'Nicholas Zolnierz', 'email': 'nicholas.zolnierz@mongodb.com', 'username': 'nzolnierzmdb'}

Message: Revert "SERVER-71237 Do not print full expected output when golden test file does not exist"

This reverts commit df38314f471a57fd273a7c0d747dfc1aeb4feaea.
Branch: master
https://github.com/mongodb/mongo/commit/607e613725fffbab18c372627d74e8607077ee82

Comment by Githook User [ 11/Nov/22 ]

Author:

{'name': 'Nicholas Zolnierz', 'email': 'nicholas.zolnierz@mongodb.com', 'username': 'nzolnierzmdb'}

Message: SERVER-71237 Do not print full expected output when golden test file does not exist
Branch: master
https://github.com/mongodb/mongo/commit/df38314f471a57fd273a7c0d747dfc1aeb4feaea

Generated at Thu Feb 08 06:18:25 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.