[SERVER-71310] Validate histograms Created: 14/Nov/22  Updated: 29/Oct/23  Resolved: 13/Dec/22

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 6.3.0-rc0

Type: Improvement Priority: Major - P3
Reporter: Alya Berciu Assignee: Alya Berciu
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by SERVER-71762 Coverity analysis defect 134254: Usin... Closed
Duplicate
is duplicated by SERVER-71701 Coverity analysis defect 134242: Usin... Closed
is duplicated by SERVER-71762 Coverity analysis defect 134254: Usin... Closed
Problem/Incident
Backwards Compatibility: Fully Compatible
Sprint: QO 2022-12-12, QO 2022-12-26
Participants:
Linked BF Score: 35

 Description   

We should add missing validation that ensures constructed histograms are valid histograms. This is especially useful in tests, but also necessary to make sure that max_diff generates correct histograms in practice.

As part of this work, we should also replace the invariants in ArrayHistogram with tasserts.



 Comments   
Comment by Githook User [ 12/Dec/22 ]

Author:

{'name': 'Alya Berciu', 'email': 'alya.berciu@mongodb.com', 'username': 'alyacb'}

Message: SERVER-71310 Validate histograms
Branch: master
https://github.com/mongodb/mongo/commit/19ee1cedb8a1fbfc6c7a73db5211a592cc96b642

Comment by Githook User [ 09/Dec/22 ]

Author:

{'name': 'Alexander Neben', 'email': 'alexander.neben@mongodb.com', 'username': 'IamXander'}

Message: Revert "SERVER-71310 Validate histograms"

This reverts commit ef685370c6e9ad3f169c9330c7b0c306f290a599.
Branch: master
https://github.com/mongodb/mongo/commit/c3d1400b558104f3944b019534097d16f1c61097

Comment by Githook User [ 09/Dec/22 ]

Author:

{'name': 'Alya Berciu', 'email': 'alya.berciu@mongodb.com', 'username': 'alyacb'}

Message: SERVER-71310 Validate histograms
Branch: master
https://github.com/mongodb/mongo/commit/ef685370c6e9ad3f169c9330c7b0c306f290a599

Generated at Thu Feb 08 06:18:39 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.