[SERVER-71375] Replace std::set<std::string> in BucketSpec and BucketUnpacker Created: 15/Nov/22 Updated: 19/Jul/23 Resolved: 19/Jul/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Ivan Fefer | Assignee: | Foteini Alvanaki |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | neweng | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Assigned Teams: |
Query Execution
|
||||
| Sprint: | QE 2023-07-24 | ||||
| Participants: | |||||
| Linked BF Score: | 0 | ||||
| Description |
|
Currently we use std::set<std::string> in BucketSpec and BucketUnpacker: https://github.com/mongodb/mongo/blob/8b473650c85276ab5d14526fbb466e961b1111b4/src/mongo/db/exec/timeseries/bucket_spec.h#L259 This forces us to do some unnecessary string copying, for example, here: We should replace it with StringSet that supports heterogeneous lookup.
|
| Comments |
| Comment by Foteini Alvanaki [ 19/Jul/23 ] |
|
The performance evaluation of the change showed no clear performance improvement. On the contrary, it suggests that this change might cause a slight performance regression in some tests in tsbs_query_finance and tsbs_query_manual_bucketing. For that, we have decided not to merge the change.
Performance results |
| Comment by Githook User [ 14/Jul/23 ] |
|
Author: {'name': 'Benety Goh', 'email': 'benety@mongodb.com', 'username': 'benety'}Message: Revert " This reverts commit 770aa707f7f9ab373129524aafbc228669782f4f. |
| Comment by Foteini Alvanaki [ 14/Jul/23 ] |
|
The merge caused a BF https://evergreen.mongodb.com/task/mongodb_mongo_master_linux_debug_aubsan_compile_required_run_unittests_770aa707f7f9ab373129524aafbc228669782f4f_23_07_14_09_23_26 |
| Comment by Githook User [ 14/Jul/23 ] |
|
Author: {'name': 'Foteini Alvanaki', 'email': 'foteini.alvanaki@mongodb.com', 'username': ''}Message: |