[SERVER-71411] Replace asyncio with explicit timeouts in metrics collection Created: 16/Nov/22  Updated: 29/Oct/23  Resolved: 28/Nov/22

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 6.2.0-rc2, 6.3.0-rc0

Type: Bug Priority: Major - P3
Reporter: Tausif Rahman (Inactive) Assignee: Tausif Rahman (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Backports
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Requested:
v6.2
Participants:

 Description   

There is no async code here, so this timeout does not really work as expected: https://github.com/10gen/mongo/blob/74aebe28de1ed67df5b3e6ff3269f0b6d59ef8e1/buildscripts/metrics/tooling_metrics_utils.py#L73

Thanks max.hirschhorn@mongodb.com for identifying a better way to do this:

We should just explicitly set timeouts in pymongo code (setting the connection timeout, the socket timeout, and maxTimeMS). Slack thread: https://mongodb.slack.com/archives/CQDQ9R413/p1668615726847349?thread_ts=1667588594.452019&cid=CQDQ9R413

(You may also want to disable retryable writes which are enabled by default in drivers because you don't want to spend extra time retrying if you get a broken network connection)

 



 Comments   
Comment by Githook User [ 28/Nov/22 ]

Author:

{'name': 'Tausif Rahman', 'email': 'tausif.rahman@mongodb.com', 'username': 'trahman1318'}

Message: SERVER-71411 Replace asyncio with explicit timeouts in metrics collection

(cherry picked from commit 93b1775dd99dfbb8b0f083e68fbf911d3d4eaf12)
Branch: v6.2
https://github.com/mongodb/mongo/commit/b6ff8ad7ad404430b05353fb6a2f8b1c01005ea3

Comment by Githook User [ 17/Nov/22 ]

Author:

{'name': 'Tausif Rahman', 'email': 'tausif.rahman@mongodb.com', 'username': 'trahman1318'}

Message: SERVER-71411 Replace asyncio with explicit timeouts in metrics collection
Branch: master
https://github.com/mongodb/mongo/commit/93b1775dd99dfbb8b0f083e68fbf911d3d4eaf12

Generated at Thu Feb 08 06:18:56 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.