[SERVER-71441] [Query] Remove or document instances of UninterruptibleLockGuard Created: 17/Nov/22  Updated: 29/Oct/23  Resolved: 03/Feb/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 6.3.0-rc0

Type: Improvement Priority: Major - P3
Reporter: Yujin Kang Park Assignee: Adi Agrawal
Resolution: Fixed Votes: 0
Labels: query-director-triage
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by SERVER-68868 Remove all instances of Uninterruptib... Blocked
Assigned Teams:
Query Execution
Backwards Compatibility: Fully Compatible
Sprint: QE 2023-02-06, QE 2023-02-20
Participants:

 Description   

SERVER-68868 intends to remove UninterruptipleLockGuard uses where possible, from its description:

Uses of UninterruptibleLockGuard indicate places in the code that do not comply with MongoDB's requirement that all operations be interruptible at places where they block to wait for resources. Every one of them is a potential future deadlock, and adds complexity to other parts of the codebase. We should reimplement codepaths that depend on UninterruptibleLockGuard so as to be interruptible.

The work has been split for the different teams in server, this one being for Query.

SERVER-68867 introduced a linter rule to add friction when adding new UninterruptipleLockGuard instances, and commented existing ones with NOLINT, while also adding a TODO with the corresponding server team ticket if an instance was found to not have a comment explaining why its use is warranted.

We should either add a comment justifying the use of UninterruptibleLockGuard or fix the code to remove its use.
Search for "TODO (SERVER-71441)" in the code:

https://github.com/10gen/mongo/blob/34ac49477b87e183637f68cda828ecff8b393c64/src/mongo/db/commands/dbcommands_d.cpp#L335



 Comments   
Comment by Githook User [ 03/Feb/23 ]

Author:

{'name': 'Adityavardhan Agrawal', 'email': 'adi.agrawal@mongodb.com', 'username': 'Adityav369'}

Message: SERVER-71441 Document UninterruptibleLockGuard usage
Branch: master
https://github.com/mongodb/mongo/commit/3c9d49064688fb26918467d51ddb794427498fae

Generated at Thu Feb 08 06:19:01 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.