[SERVER-71443] [Replication] Remove or document instances of UninterruptibleLockGuard Created: 17/Nov/22 Updated: 29/Oct/23 Resolved: 20/Apr/23 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 7.1.0-rc0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Yujin Kang Park | Assignee: | Ali Mir |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | repl-shortlist | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Assigned Teams: |
Replication
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Sprint: | Repl 2023-04-03, Repl 2023-04-17, Repl 2023-05-01 | ||||||||
| Participants: | |||||||||
| Description |
|
SERVER-68868 intends to remove UninterruptipleLockGuard uses where possible, from its description: Uses of UninterruptibleLockGuard indicate places in the code that do not comply with MongoDB's requirement that all operations be interruptible at places where they block to wait for resources. Every one of them is a potential future deadlock, and adds complexity to other parts of the codebase. We should reimplement codepaths that depend on UninterruptibleLockGuard so as to be interruptible. The work has been split for the different teams in server, this one being for Replication.
We should either add a comment justifying the use of UninterruptibleLockGuard or fix the code to remove its use. https://github.com/10gen/mongo/blob/34ac49477b87e183637f68cda828ecff8b393c64/src/mongo/db/repl/oplog_buffer_collection.cpp#L464 The following instances were initially categorised as StorEx, but should probably done by Replication: |
| Comments |
| Comment by Githook User [ 19/Apr/23 ] |
|
Author: {'name': 'Ali Mir', 'email': 'ali.mir@mongodb.com', 'username': 'ali-mir'}Message: |