[SERVER-71466] Ensure _donorOplogBuffer is always accessed under mutex Created: 17/Nov/22  Updated: 29/Oct/23  Resolved: 06/Apr/23

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 7.0.0-rc0

Type: Bug Priority: Major - P3
Reporter: Christopher Caplinger Assignee: Christopher Caplinger
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Server Serverless 2022-11-28, Server Serverless 2022-12-12, Server Serverless 2022-12-26, Server Serverless 2023-01-09, Server Serverless 2023-01-23, Server Serverless 2023-02-06, Server Serverless 2023-02-20, Server Serverless 2023-03-06, Server Serverless 2023-03-20, Server Serverless 2023-04-03, Server Serverless 2023-04-17
Participants:

 Description   

see https://github.com/10gen/mongo/blob/1301f35e5dcb08e55d79c7213cc48165c2b49156/src/mongo/db/repl/tenant_migration_recipient_service.cpp#L1834

although this is technically safe right now (nothing concurrently accesses the buffer), _donorOplogBuffer is marked with (M) signifying that it must be accessed while holding a mutex. we should clean this up and make this explicit.

also investigate other properties where this might be the case.



 Comments   
Comment by Githook User [ 24/Mar/23 ]

Author:

{'name': 'Christopher Caplinger', 'email': 'christopher.caplinger@mongodb.com', 'username': 'UnicodeSnowman'}

Message: SERVER-71466: Ensure _donorOplogBuffer is only used while holding shared ptr
Branch: master
https://github.com/mongodb/mongo/commit/e36ba795e845a7a86cdd9a4e055f7b812b0219c9

Generated at Thu Feb 08 06:19:05 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.